Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Celer benchmark #1369

Merged
merged 2 commits into from
Aug 2, 2023
Merged

feat: Celer benchmark #1369

merged 2 commits into from
Aug 2, 2023

Conversation

Rumata888
Copy link
Contributor

@Rumata888 Rumata888 commented Aug 2, 2023 •
edited
Loading

Description

The part of the code that we need on our side to enable celer zk benchmark

Checklist:

  • I have reviewed my diff in github, line by line.
  • Every change is related to the PR description.
  • I have linked this pull request to the issue(s) that it resolves.
  • There are no unexpected formatting changes, superfluous debug logs, or commented-out code.
  • The branch has been merged or rebased against the head of its merge target.
  • I'm happy for the PR to be merged at the reviewer's next convenience.

@Rumata888 Rumata888 changed the title Celer benchmark feat: Celer benchmark Aug 2, 2023
@Rumata888 Rumata888 requested a review from ludamad August 2, 2023 14:48
@Rumata888 Rumata888 marked this pull request as ready for review August 2, 2023 14:48
ludamad
ludamad reviewed Aug 2, 2023
View reviewed changes
circuits/cpp/barretenberg/cpp/src/barretenberg/stdlib/hash/benchmarks/celer/sha256.bench.cpp

// Because of the way we do internal allocations in some of our more complex structures, we can't just globally allocate
// them
Builder* builders[NUM_HASHES];
Copy link
Collaborator

@ludamad ludamad Aug 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Could be one global pointer to a struct with all of these (but I'm generally fine if people keep it in mind for next PR that touches this)

ludamad
ludamad approved these changes Aug 2, 2023
View reviewed changes
Copy link
Collaborator

@ludamad ludamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, LGTM

@ludamad ludamad added the crypto cryptography label Aug 2, 2023
@Rumata888 Rumata888 merged commit 7ec6b32 into master Aug 2, 2023
@Rumata888 Rumata888 deleted the is/celer-specific-bench branch August 2, 2023 15:14
@Rumata888 Rumata888 self-assigned this Aug 2, 2023
@github-actions github-actions bot mentioned this pull request Sep 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludamad ludamad ludamad approved these changes

Assignees

@Rumata888 Rumata888

Labels
crypto cryptography
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rumata888 @ludamad