Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate call stack validation in PKC #1394

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Conversation

suyash67
Copy link
Contributor

@suyash67 suyash67 commented Aug 3, 2023

Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.

resolves #499, #671

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@suyash67 suyash67 force-pushed the sb/reinstate-callstack-check branch from 14d9eba to cb5463d Compare August 3, 2023 22:09
@suyash67 suyash67 marked this pull request as ready for review August 3, 2023 22:42
@suyash67 suyash67 requested a review from dbanks12 August 3, 2023 22:42
Copy link
Collaborator

@dbanks12 dbanks12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work!

@dbanks12 dbanks12 merged commit 801f6a5 into master Aug 3, 2023
@dbanks12 dbanks12 deleted the sb/reinstate-callstack-check branch August 3, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Adding hash index in noir for private call stack item
3 participants