Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add expression width into acir #4014

Merged
merged 20 commits into from
Feb 5, 2024
Merged

feat!: Add expression width into acir #4014

merged 20 commits into from
Feb 5, 2024

Conversation

guipublic
Copy link
Contributor

@guipublic guipublic commented Jan 15, 2024

Resolves Noir issue noir-lang/noir#4012, by adding ExpressionWidth into acir.
The PR simply account for this new field and update the serialisation. It also set the width during csat transformation phase.

@guipublic guipublic marked this pull request as ready for review February 1, 2024 15:33
@AztecBot
Copy link
Collaborator

AztecBot commented Feb 2, 2024

Benchmark results

No metrics with a significant change found.

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit d953090c and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 8 txs 32 txs 128 txs
l1_rollup_calldata_size_in_bytes 45,636 180,516 720,036
l1_rollup_calldata_gas 222,576 870,972 3,465,636
l1_rollup_execution_gas 315,063 988,712 3,685,293
l2_block_processing_time_in_ms 1,166 (+1%) 4,373 17,435 (+1%)
note_successful_decrypting_time_in_ms 311 (+3%) 1,007 (+2%) 3,849 (+4%)
note_trial_decrypting_time_in_ms 24.7 (+69%) 132 (+9%) 152
l2_block_building_time_in_ms 17,930 70,490 283,149
l2_block_rollup_simulation_time_in_ms 13,083 51,728 208,279
l2_block_public_tx_process_time_in_ms 4,758 18,677 74,547

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric 5 blocks 10 blocks
node_history_sync_time_in_ms 13,863 (-1%) 26,223 (-2%)
note_history_successful_decrypting_time_in_ms 2,307 (-6%) 4,552 (-5%)
note_history_trial_decrypting_time_in_ms 175 (+59%) 213 (-7%)
node_database_size_in_bytes 17,371,216 33,091,664
pxe_database_size_in_bytes 29,923 59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit circuit_simulation_time_in_ms circuit_input_size_in_bytes circuit_output_size_in_bytes
private-kernel-init 309 44,481 26,193
private-kernel-ordering 194 (-1%) 44,513 14,929
base-rollup 1,404 128,970 881
root-rollup 82.8 4,088 677
private-kernel-inner 416 71,640 26,193
public-kernel-private-input 240 32,615 26,193
public-kernel-non-first-iteration 239 32,657 26,193
merge-rollup 7.81 (+1%) 2,608 881

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 2 leaves 8 leaves 16 leaves 32 leaves 128 leaves 64 leaves 512 leaves 1024 leaves 2048 leaves 8192 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.2 13.2 (+18%) 12.6 17.0 (-3%) 22.9 64.5 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.9 17.5 23.0 31.6 47.0 143 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.593 0.732 (+17%) 0.538 0.526 (-2%) 0.478 0.443 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A N/A N/A N/A 79.2 (+5%) 47.6 240 461 (-1%) 904 3,576
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A N/A N/A N/A 159 96.0 543 1,055 2,079 8,223
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A N/A N/A N/A 0.488 (+5%) 0.488 0.437 0.432 0.430 0.429
batch_insert_into_indexed_tree_20_depth_ms N/A N/A N/A N/A N/A 108 (+3%) 56.8 355 (+2%) 688 (-1%) 1,365 5,461 (+1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A N/A N/A N/A 197 104 691 1,363 2,707 10,771
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A N/A N/A N/A 0.507 (+2%) 0.497 0.482 (+2%) 0.473 0.473 0.473
batch_insert_into_indexed_tree_40_depth_ms N/A N/A N/A 56.7 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A N/A 94.1 N/A N/A N/A N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A N/A 0.578 N/A N/A N/A N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric 0 deployed contracts 1 deployed contracts
tx_size_in_bytes 15,575 38,325

Transaction processing duration by data writes.

Metric 0 new commitments 1 new commitments
tx_pxe_processing_time_ms 556 1,229
Metric 0 public data writes 1 public data writes
tx_sequencer_processing_time_ms 0.541 (-19%) 576 (-1%)

@kevaundray kevaundray enabled auto-merge (squash) February 5, 2024 12:51
@kevaundray kevaundray merged commit f09e8fc into master Feb 5, 2024
81 of 83 checks passed
@kevaundray kevaundray deleted the gd/noir_issue_4012 branch February 5, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants