fix: mul with endomorphism #4538

ludamad · 2024-02-10T00:23:41Z

Previously, batch_mul_with_endomorphism and mul_with_endomorphism did not consider points at infinity. This caused either invert-0 errors or incorrect results when the point at infinity was multiplied by any scalar.

The inconsistency between getting invert-0 errors is probably something worth following up on.

…x/endo-infinite

AztecBot · 2024-02-10T04:17:16Z

Benchmark results

Metrics with a significant change:

note_history_trial_decrypting_time_in_ms (5): 163 (+81%)

Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Values are compared against data from master at commit 1fe674b0 and shown if the difference exceeds 1%.

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric	8 txs	32 txs	128 txs
l1_rollup_calldata_size_in_bytes	45,956	181,604	724,196
l1_rollup_calldata_gas	227,168	888,824	3,535,856
l1_rollup_execution_gas	320,359	1,007,272	3,756,234
l2_block_processing_time_in_ms	1,154	4,372 (+1%)	17,276
note_successful_decrypting_time_in_ms	305 (-2%)	969 (-1%)	3,614 (-3%)
note_trial_decrypting_time_in_ms	15.8 (-32%)	99.9 (-6%)	146 (-5%)
l2_block_building_time_in_ms	18,251	72,068	288,291
l2_block_rollup_simulation_time_in_ms	13,462	53,480	214,266
l2_block_public_tx_process_time_in_ms	4,702 (+1%)	18,515	73,766 (-1%)

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 16 txs.

Metric	5 blocks	10 blocks
node_history_sync_time_in_ms	14,917 (+1%)	28,988 (-2%)
note_history_successful_decrypting_time_in_ms	2,288 (-8%)	4,536 (-3%)
note_history_trial_decrypting_time_in_ms	⚠️ 163 (+81%)	210 (+17%)
node_database_size_in_bytes	17,281,104	33,230,928
pxe_database_size_in_bytes	29,923	59,478

Circuits stats

Stats on running time and I/O sizes collected for every circuit run across all benchmarks.

Circuit	circuit_simulation_time_in_ms	circuit_input_size_in_bytes	circuit_output_size_in_bytes
private-kernel-init	326 (-1%)	44,528	25,313
private-kernel-ordering	196	43,633	16,193
base-rollup	1,455 (-3%)	129,774	933
root-rollup	82.3 (-1%)	4,192	729
private-kernel-inner	435	70,819	25,313
public-kernel-private-input	238 (-4%)	33,663	26,945
public-kernel-non-first-iteration	238 (-4%)	33,705	26,945
merge-rollup	7.81 (-2%)	2,712	933

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric	1 leaves	2 leaves	8 leaves	16 leaves	32 leaves	128 leaves	64 leaves	512 leaves	1024 leaves	2048 leaves	8192 leaves
batch_insert_into_append_only_tree_16_depth_ms	10.2 (-1%)	10.6 (-6%)	12.7	16.6 (-2%)	22.8	64.3	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_count	16.9	17.5	23.0	31.6	47.0	143	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_16_depth_hash_ms	0.592 (-1%)	0.592 (-6%)	0.540	0.514 (-2%)	0.478	0.442	N/A	N/A	N/A	N/A	N/A
batch_insert_into_append_only_tree_32_depth_ms	N/A	N/A	N/A	N/A	N/A	74.9	47.5	239	460 (-1%)	903 (+1%)	3,560
batch_insert_into_append_only_tree_32_depth_hash_count	N/A	N/A	N/A	N/A	N/A	159	96.0	543	1,055	2,079	8,223
batch_insert_into_append_only_tree_32_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.463	0.488	0.436	0.431 (-1%)	0.428	0.428
batch_insert_into_indexed_tree_20_depth_ms	N/A	N/A	N/A	N/A	N/A	103 (-2%)	56.7	348 (-1%)	684 (-1%)	1,357 (-1%)	5,435
batch_insert_into_indexed_tree_20_depth_hash_count	N/A	N/A	N/A	N/A	N/A	197	104	691	1,363	2,707	10,771
batch_insert_into_indexed_tree_20_depth_hash_ms	N/A	N/A	N/A	N/A	N/A	0.493 (-1%)	0.495	0.474	0.472 (-1%)	0.471 (-1%)	0.473
batch_insert_into_indexed_tree_40_depth_ms	N/A	N/A	N/A	56.4 (-1%)	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_count	N/A	N/A	N/A	94.1	N/A	N/A	N/A	N/A	N/A	N/A	N/A
batch_insert_into_indexed_tree_40_depth_hash_ms	N/A	N/A	N/A	0.578	N/A	N/A	N/A	N/A	N/A	N/A	N/A

Miscellaneous

Transaction sizes based on how many contracts are deployed in the tx.

Metric	0 deployed contracts	1 deployed contracts
tx_size_in_bytes	16,859	39,794

Transaction processing duration by data writes.

Metric	0 new commitments	1 new commitments
tx_pxe_processing_time_ms	550 (-1%)	1,437 (-1%)

Metric	0 public data writes	1 public data writes
tx_sequencer_processing_time_ms	0.490 (-8%)	572 (-4%)

ludamad · 2024-02-12T10:40:30Z

barretenberg/cpp/scripts/benchmark_remote.sh

@@ -9,20 +9,19 @@ set -eu

 BENCHMARK=${1:-goblin_bench}
 COMMAND=${2:-./$BENCHMARK}
+PRESET=${3:-clang16}
+BUILD_DIR=${4:-build}


Just lets us remote benchmark other presets + build folders

…inite

…x/endo-infinite

Rumata888 · 2024-02-12T13:10:11Z

barretenberg/cpp/src/barretenberg/ecc/fields/field_declarations.hpp

        }
+    }
+
+    static std::pair<std::array<uint64_t, 2>, std::array<uint64_t, 2>> split_into_endomorphism_scalars_no_shift(


Why is it called "no_shift"?

I was trying to find a good name as is the counter part to this case technically, but I may be off the mark

I'll just call it split_into_endomorphism_scalars, though, I think. If it was ever misused the static assert will catch it

You can specify that it works for values less than 256 bits if you want, but shift means something else, so it's a bit confusing

barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.test.cpp

Rumata888 · 2024-02-12T13:22:19Z

barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.test.cpp

+};
+} // namespace bb::group_elements
+
+TEST(AffineElement, EndoMulMatchesNonEndo)


Could you please expand the names of the tests? If a person has no context, they have to look inside the test to understand what's happening

Rumata888 · 2024-02-12T13:26:23Z

barretenberg/cpp/src/barretenberg/ecc/groups/element_impl.hpp

 }

+namespace detail {
+using EndoScalars = std::pair<std::array<uint64_t, 2>, std::array<uint64_t, 2>>;
+template <typename Element, std::size_t NUM_ROUNDS> struct EndomorphismWnaf {


Could you please leave comments specifying what the purpose of this class is.

Rumata888 · 2024-02-12T13:28:03Z

barretenberg/cpp/src/barretenberg/ecc/groups/element_impl.hpp

-        element result{ Fq::zero(), Fq::zero(), Fq::zero() };
-        result.self_set_infinity();
-        return result;
+    if (converted_scalar.is_zero() || is_point_at_infinity()) {


I'd move it above line 640, then you avoid useless multiplication in conversion from montgomery

Sure. I was wondering how much we cared about optimizing infinity points vs readability, but I can move it up

Rumata888

Looks good, I'd just leave a few more comments in various parts to make it easier for somebody else to follow the logic and move one of the comparisons, so we avoid useless work

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([#4479](#4479)) * note type ids ([#4500](#4500)) ### Features * Add fee payment methods ([#4504](#4504)) ([d107746](d107746)) * Add hashing to stdlib transcript ([#4161](#4161)) ([e78b86f](e78b86f)) * Added cast opcode and cast calldata ([#4423](#4423)) ([e58eda8](e58eda8)) * Added cast opcode and cast calldata (#4423) ([db803bd](db803bd)) * **avm-transpiler:** Implement tags for SET and others ([#4545](#4545)) ([3063bf3](3063bf3)) * **avm:** Implement addressing modes for MOV ([#4490](#4490)) ([ab4eaf0](ab4eaf0)) * **avm:** Introduce small e2e test ([#4470](#4470)) ([7b4c6e7](7b4c6e7)) * Aztec.js API for registering a contract class ([#4469](#4469)) ([d566c74](d566c74)) * **docs:** DIP1 - Extracting how-tos ([#4251](#4251)) ([9d50e24](9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([#4480](#4480)) ([5fc02e7](5fc02e7)) * IVC bench ([#4515](#4515)) ([d8ae42b](d8ae42b)) * Nicer API for instance deployment ([#4493](#4493)) ([99c3fba](99c3fba)) * Note type ids ([#4500](#4500)) ([e1da2fd](e1da2fd)) * Op count timers ([#4471](#4471)) ([26918de](26918de)) * PG + Goblin ([#4399](#4399)) ([295cd55](295cd55)) * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) * Update rollup circuits and contracts in yp ([#4536](#4536)) ([6e89d53](6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([#4523](#4523)) ([4982e3c](4982e3c)) * Broken links in docs [REDO] ([#4540](#4540)) ([ce2a205](ce2a205)) * **build-system:** Image expiring ([#4521](#4521)) ([1501afd](1501afd)) * Convert folding recursive verifier ops to batch mul ([#4517](#4517)) ([3750b26](3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](#4494)) ([fecf3f7](fecf3f7)) * Field divison / journal comparisions ([#4489](#4489)) ([15c06c5](15c06c5)) * Master ([#4547](#4547)) ([490ca26](490ca26)) * Mirror_noir_subrepo.yml ([#4550](#4550)) ([f8d8311](f8d8311)) * Mul with endomorphism ([#4538](#4538)) ([1f4c90d](1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([#4555](#4555)) ([686140a](686140a)) * Recreate jest.config.ts for sequencer-client ([#4553](#4553)) ([d172f0b](d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](#4530)) ([ce51d20](ce51d20)) * Use ordered-binary value encoding for multi maps ([#4565](#4565)) ([04ae0d2](04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([#4510](#4510)) ([47d66f9](47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](#4554)) ([ca4dd60](ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([#4542](#4542)) ([da2f5ed](da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([#4484](#4484)) ([2fccdf2](2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([#4516](#4516)) ([87a9663](87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](#4502)) ([bf4fc6c](bf4fc6c)), closes [#4495](#4495) * Cleanup of `abi.nr` in `aztec-nr` ([#4473](#4473)) ([6d9c73a](6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (#4473) [skip ci] ([db803bd](db803bd)) * Create constraints for sha256 compression opcode ([#4503](#4503)) ([64bef49](64bef49)) * Little cpp style improvements ([#4528](#4528)) ([dcc9ba4](dcc9ba4)) * Move noir out of yarn-project ([#4479](#4479)) ([1fe674b](1fe674b)), closes [#4107](#4107) * Pull noir ([#4546](#4546)) ([acf5cf2](acf5cf2)) * Pull noir (#4546) ([db803bd](db803bd)) * Redo noir subrepo force push ([#4514](#4514)) ([7b519a4](7b519a4)) * Remove .oldValue in contract state update request ([#4499](#4499)) ([a796bef](a796bef)) * Removing redundant utilities ([#4532](#4532)) ([79bf445](79bf445)), closes [#3470](#3470) * Rename kernel circuits and disambiguate inputs ([#4535](#4535)) ([ed6d521](ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](101ab59)) * Simulator utils cleanup ([#4507](#4507)) ([1dd0ebf](1dd0ebf)) * Sync to noir-lang/noir ([db803bd](db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([#4481](#4481)) ([bc25f9b](bc25f9b)) * Testing historical header in contexts ([#4509](#4509)) ([c00229a](c00229a)) * Updating field conversion code without pointer hack ([#4537](#4537)) ([94f436e](94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([#4511](#4511)) ([9dc05bc](9dc05bc)) ### Documentation * Describe the new message box model ([#4485](#4485)) ([14cc1dd](14cc1dd)) * Review of docs, so far ([#4505](#4505)) ([140c508](140c508)) * **yellowpaper:** Avm tree-access operations ([#4552](#4552)) ([913f4bd](913f4bd)) * **yellowpaper:** Separate section for AVM state ([#4440](#4440)) ([7881f09](7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([#4161](#4161)) ([e78b86f](e78b86f)) * Added cast opcode and cast calldata ([#4423](#4423)) ([e58eda8](e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([#4480](#4480)) ([5fc02e7](5fc02e7)) * IVC bench ([#4515](#4515)) ([d8ae42b](d8ae42b)) * Op count timers ([#4471](#4471)) ([26918de](26918de)) * PG + Goblin ([#4399](#4399)) ([295cd55](295cd55)) * Prototype native merkle trees ([#4457](#4457)) ([7d5e056](7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([#4517](#4517)) ([3750b26](3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](#4494)) ([fecf3f7](fecf3f7)) * Mul with endomorphism ([#4538](#4538)) ([1f4c90d](1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](#4530)) ([ce51d20](ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](#4554)) ([ca4dd60](ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](#4502)) ([bf4fc6c](bf4fc6c)), closes [#4495](#4495) * Create constraints for sha256 compression opcode ([#4503](#4503)) ([64bef49](64bef49)) * Little cpp style improvements ([#4528](#4528)) ([dcc9ba4](dcc9ba4)) * Updating field conversion code without pointer hack ([#4537](#4537)) ([94f436e](94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([#4552](#4552)) ([913f4bd](913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([#4479](AztecProtocol/aztec-packages#4479)) * note type ids ([#4500](AztecProtocol/aztec-packages#4500)) ### Features * Add fee payment methods ([#4504](AztecProtocol/aztec-packages#4504)) ([d107746](AztecProtocol/aztec-packages@d107746)) * Add hashing to stdlib transcript ([#4161](AztecProtocol/aztec-packages#4161)) ([e78b86f](AztecProtocol/aztec-packages@e78b86f)) * Added cast opcode and cast calldata ([#4423](AztecProtocol/aztec-packages#4423)) ([e58eda8](AztecProtocol/aztec-packages@e58eda8)) * Added cast opcode and cast calldata (AztecProtocol/aztec-packages#4423) ([db803bd](AztecProtocol/aztec-packages@db803bd)) * **avm-transpiler:** Implement tags for SET and others ([#4545](AztecProtocol/aztec-packages#4545)) ([3063bf3](AztecProtocol/aztec-packages@3063bf3)) * **avm:** Implement addressing modes for MOV ([#4490](AztecProtocol/aztec-packages#4490)) ([ab4eaf0](AztecProtocol/aztec-packages@ab4eaf0)) * **avm:** Introduce small e2e test ([#4470](AztecProtocol/aztec-packages#4470)) ([7b4c6e7](AztecProtocol/aztec-packages@7b4c6e7)) * Aztec.js API for registering a contract class ([#4469](AztecProtocol/aztec-packages#4469)) ([d566c74](AztecProtocol/aztec-packages@d566c74)) * **docs:** DIP1 - Extracting how-tos ([#4251](AztecProtocol/aztec-packages#4251)) ([9d50e24](AztecProtocol/aztec-packages@9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([#4480](AztecProtocol/aztec-packages#4480)) ([5fc02e7](AztecProtocol/aztec-packages@5fc02e7)) * IVC bench ([#4515](AztecProtocol/aztec-packages#4515)) ([d8ae42b](AztecProtocol/aztec-packages@d8ae42b)) * Nicer API for instance deployment ([#4493](AztecProtocol/aztec-packages#4493)) ([99c3fba](AztecProtocol/aztec-packages@99c3fba)) * Note type ids ([#4500](AztecProtocol/aztec-packages#4500)) ([e1da2fd](AztecProtocol/aztec-packages@e1da2fd)) * Op count timers ([#4471](AztecProtocol/aztec-packages#4471)) ([26918de](AztecProtocol/aztec-packages@26918de)) * PG + Goblin ([#4399](AztecProtocol/aztec-packages#4399)) ([295cd55](AztecProtocol/aztec-packages@295cd55)) * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) * Update rollup circuits and contracts in yp ([#4536](AztecProtocol/aztec-packages#4536)) ([6e89d53](AztecProtocol/aztec-packages@6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([#4523](AztecProtocol/aztec-packages#4523)) ([4982e3c](AztecProtocol/aztec-packages@4982e3c)) * Broken links in docs [REDO] ([#4540](AztecProtocol/aztec-packages#4540)) ([ce2a205](AztecProtocol/aztec-packages@ce2a205)) * **build-system:** Image expiring ([#4521](AztecProtocol/aztec-packages#4521)) ([1501afd](AztecProtocol/aztec-packages@1501afd)) * Convert folding recursive verifier ops to batch mul ([#4517](AztecProtocol/aztec-packages#4517)) ([3750b26](AztecProtocol/aztec-packages@3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](AztecProtocol/aztec-packages#4494)) ([fecf3f7](AztecProtocol/aztec-packages@fecf3f7)) * Field divison / journal comparisions ([#4489](AztecProtocol/aztec-packages#4489)) ([15c06c5](AztecProtocol/aztec-packages@15c06c5)) * Master ([#4547](AztecProtocol/aztec-packages#4547)) ([490ca26](AztecProtocol/aztec-packages@490ca26)) * Mirror_noir_subrepo.yml ([#4550](AztecProtocol/aztec-packages#4550)) ([f8d8311](AztecProtocol/aztec-packages@f8d8311)) * Mul with endomorphism ([#4538](AztecProtocol/aztec-packages#4538)) ([1f4c90d](AztecProtocol/aztec-packages@1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([#4555](AztecProtocol/aztec-packages#4555)) ([686140a](AztecProtocol/aztec-packages@686140a)) * Recreate jest.config.ts for sequencer-client ([#4553](AztecProtocol/aztec-packages#4553)) ([d172f0b](AztecProtocol/aztec-packages@d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](AztecProtocol/aztec-packages#4530)) ([ce51d20](AztecProtocol/aztec-packages@ce51d20)) * Use ordered-binary value encoding for multi maps ([#4565](AztecProtocol/aztec-packages#4565)) ([04ae0d2](AztecProtocol/aztec-packages@04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([#4510](AztecProtocol/aztec-packages#4510)) ([47d66f9](AztecProtocol/aztec-packages@47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](AztecProtocol/aztec-packages#4554)) ([ca4dd60](AztecProtocol/aztec-packages@ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([#4542](AztecProtocol/aztec-packages#4542)) ([da2f5ed](AztecProtocol/aztec-packages@da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([#4484](AztecProtocol/aztec-packages#4484)) ([2fccdf2](AztecProtocol/aztec-packages@2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([#4516](AztecProtocol/aztec-packages#4516)) ([87a9663](AztecProtocol/aztec-packages@87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](AztecProtocol/aztec-packages#4502)) ([bf4fc6c](AztecProtocol/aztec-packages@bf4fc6c)), closes [#4495](AztecProtocol/aztec-packages#4495) * Cleanup of `abi.nr` in `aztec-nr` ([#4473](AztecProtocol/aztec-packages#4473)) ([6d9c73a](AztecProtocol/aztec-packages@6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (AztecProtocol/aztec-packages#4473) [skip ci] ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Create constraints for sha256 compression opcode ([#4503](AztecProtocol/aztec-packages#4503)) ([64bef49](AztecProtocol/aztec-packages@64bef49)) * Little cpp style improvements ([#4528](AztecProtocol/aztec-packages#4528)) ([dcc9ba4](AztecProtocol/aztec-packages@dcc9ba4)) * Move noir out of yarn-project ([#4479](AztecProtocol/aztec-packages#4479)) ([1fe674b](AztecProtocol/aztec-packages@1fe674b)), closes [#4107](AztecProtocol/aztec-packages#4107) * Pull noir ([#4546](AztecProtocol/aztec-packages#4546)) ([acf5cf2](AztecProtocol/aztec-packages@acf5cf2)) * Pull noir (AztecProtocol/aztec-packages#4546) ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Redo noir subrepo force push ([#4514](AztecProtocol/aztec-packages#4514)) ([7b519a4](AztecProtocol/aztec-packages@7b519a4)) * Remove .oldValue in contract state update request ([#4499](AztecProtocol/aztec-packages#4499)) ([a796bef](AztecProtocol/aztec-packages@a796bef)) * Removing redundant utilities ([#4532](AztecProtocol/aztec-packages#4532)) ([79bf445](AztecProtocol/aztec-packages@79bf445)), closes [#3470](AztecProtocol/aztec-packages#3470) * Rename kernel circuits and disambiguate inputs ([#4535](AztecProtocol/aztec-packages#4535)) ([ed6d521](AztecProtocol/aztec-packages@ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](AztecProtocol/aztec-packages@f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](AztecProtocol/aztec-packages@20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](AztecProtocol/aztec-packages@101ab59)) * Simulator utils cleanup ([#4507](AztecProtocol/aztec-packages#4507)) ([1dd0ebf](AztecProtocol/aztec-packages@1dd0ebf)) * Sync to noir-lang/noir ([db803bd](AztecProtocol/aztec-packages@db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([#4481](AztecProtocol/aztec-packages#4481)) ([bc25f9b](AztecProtocol/aztec-packages@bc25f9b)) * Testing historical header in contexts ([#4509](AztecProtocol/aztec-packages#4509)) ([c00229a](AztecProtocol/aztec-packages@c00229a)) * Updating field conversion code without pointer hack ([#4537](AztecProtocol/aztec-packages#4537)) ([94f436e](AztecProtocol/aztec-packages@94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([#4511](AztecProtocol/aztec-packages#4511)) ([9dc05bc](AztecProtocol/aztec-packages@9dc05bc)) ### Documentation * Describe the new message box model ([#4485](AztecProtocol/aztec-packages#4485)) ([14cc1dd](AztecProtocol/aztec-packages@14cc1dd)) * Review of docs, so far ([#4505](AztecProtocol/aztec-packages#4505)) ([140c508](AztecProtocol/aztec-packages@140c508)) * **yellowpaper:** Avm tree-access operations ([#4552](AztecProtocol/aztec-packages#4552)) ([913f4bd](AztecProtocol/aztec-packages@913f4bd)) * **yellowpaper:** Separate section for AVM state ([#4440](AztecProtocol/aztec-packages#4440)) ([7881f09](AztecProtocol/aztec-packages@7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([#4161](AztecProtocol/aztec-packages#4161)) ([e78b86f](AztecProtocol/aztec-packages@e78b86f)) * Added cast opcode and cast calldata ([#4423](AztecProtocol/aztec-packages#4423)) ([e58eda8](AztecProtocol/aztec-packages@e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([#4480](AztecProtocol/aztec-packages#4480)) ([5fc02e7](AztecProtocol/aztec-packages@5fc02e7)) * IVC bench ([#4515](AztecProtocol/aztec-packages#4515)) ([d8ae42b](AztecProtocol/aztec-packages@d8ae42b)) * Op count timers ([#4471](AztecProtocol/aztec-packages#4471)) ([26918de](AztecProtocol/aztec-packages@26918de)) * PG + Goblin ([#4399](AztecProtocol/aztec-packages#4399)) ([295cd55](AztecProtocol/aztec-packages@295cd55)) * Prototype native merkle trees ([#4457](AztecProtocol/aztec-packages#4457)) ([7d5e056](AztecProtocol/aztec-packages@7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([#4517](AztecProtocol/aztec-packages#4517)) ([3750b26](AztecProtocol/aztec-packages@3750b26)) * Cycle_group validate_is_on_curve bug ([#4494](AztecProtocol/aztec-packages#4494)) ([fecf3f7](AztecProtocol/aztec-packages@fecf3f7)) * Mul with endomorphism ([#4538](AztecProtocol/aztec-packages#4538)) ([1f4c90d](AztecProtocol/aztec-packages@1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([#4530](AztecProtocol/aztec-packages#4530)) ([ce51d20](AztecProtocol/aztec-packages@ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([#4554](AztecProtocol/aztec-packages#4554)) ([ca4dd60](AztecProtocol/aztec-packages@ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([#4502](AztecProtocol/aztec-packages#4502)) ([bf4fc6c](AztecProtocol/aztec-packages@bf4fc6c)), closes [#4495](AztecProtocol/aztec-packages#4495) * Create constraints for sha256 compression opcode ([#4503](AztecProtocol/aztec-packages#4503)) ([64bef49](AztecProtocol/aztec-packages@64bef49)) * Little cpp style improvements ([#4528](AztecProtocol/aztec-packages#4528)) ([dcc9ba4](AztecProtocol/aztec-packages@dcc9ba4)) * Updating field conversion code without pointer hack ([#4537](AztecProtocol/aztec-packages#4537)) ([94f436e](AztecProtocol/aztec-packages@94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([#4552](AztecProtocol/aztec-packages#4552)) ([913f4bd](AztecProtocol/aztec-packages@913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Previously, batch_mul_with_endomorphism and mul_with_endomorphism did not consider points at infinity. This caused either invert-0 errors or incorrect results when the point at infinity was multiplied by any scalar. The inconsistency between getting invert-0 errors is probably something worth following up on. --------- Co-authored-by: ludamad <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@aztec-packages-v0.23.0...aztec-packages-v0.24.0) (2024-02-13) ### ⚠ BREAKING CHANGES * move noir out of yarn-project ([AztecProtocol#4479](AztecProtocol#4479)) * note type ids ([AztecProtocol#4500](AztecProtocol#4500)) ### Features * Add fee payment methods ([AztecProtocol#4504](AztecProtocol#4504)) ([d107746](AztecProtocol@d107746)) * Add hashing to stdlib transcript ([AztecProtocol#4161](AztecProtocol#4161)) ([e78b86f](AztecProtocol@e78b86f)) * Added cast opcode and cast calldata ([AztecProtocol#4423](AztecProtocol#4423)) ([e58eda8](AztecProtocol@e58eda8)) * Added cast opcode and cast calldata (AztecProtocol#4423) ([db803bd](AztecProtocol@db803bd)) * **avm-transpiler:** Implement tags for SET and others ([AztecProtocol#4545](AztecProtocol#4545)) ([3063bf3](AztecProtocol@3063bf3)) * **avm:** Implement addressing modes for MOV ([AztecProtocol#4490](AztecProtocol#4490)) ([ab4eaf0](AztecProtocol@ab4eaf0)) * **avm:** Introduce small e2e test ([AztecProtocol#4470](AztecProtocol#4470)) ([7b4c6e7](AztecProtocol@7b4c6e7)) * Aztec.js API for registering a contract class ([AztecProtocol#4469](AztecProtocol#4469)) ([d566c74](AztecProtocol@d566c74)) * **docs:** DIP1 - Extracting how-tos ([AztecProtocol#4251](AztecProtocol#4251)) ([9d50e24](AztecProtocol@9d50e24)) * Enable gmock and upgrade gtest to 1.13 ([AztecProtocol#4480](AztecProtocol#4480)) ([5fc02e7](AztecProtocol@5fc02e7)) * IVC bench ([AztecProtocol#4515](AztecProtocol#4515)) ([d8ae42b](AztecProtocol@d8ae42b)) * Nicer API for instance deployment ([AztecProtocol#4493](AztecProtocol#4493)) ([99c3fba](AztecProtocol@99c3fba)) * Note type ids ([AztecProtocol#4500](AztecProtocol#4500)) ([e1da2fd](AztecProtocol@e1da2fd)) * Op count timers ([AztecProtocol#4471](AztecProtocol#4471)) ([26918de](AztecProtocol@26918de)) * PG + Goblin ([AztecProtocol#4399](AztecProtocol#4399)) ([295cd55](AztecProtocol@295cd55)) * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) * Update rollup circuits and contracts in yp ([AztecProtocol#4536](AztecProtocol#4536)) ([6e89d53](AztecProtocol@6e89d53)) ### Bug Fixes * **bb:** Publishing bb for mac intel ([AztecProtocol#4523](AztecProtocol#4523)) ([4982e3c](AztecProtocol@4982e3c)) * Broken links in docs [REDO] ([AztecProtocol#4540](AztecProtocol#4540)) ([ce2a205](AztecProtocol@ce2a205)) * **build-system:** Image expiring ([AztecProtocol#4521](AztecProtocol#4521)) ([1501afd](AztecProtocol@1501afd)) * Convert folding recursive verifier ops to batch mul ([AztecProtocol#4517](AztecProtocol#4517)) ([3750b26](AztecProtocol@3750b26)) * Cycle_group validate_is_on_curve bug ([AztecProtocol#4494](AztecProtocol#4494)) ([fecf3f7](AztecProtocol@fecf3f7)) * Field divison / journal comparisions ([AztecProtocol#4489](AztecProtocol#4489)) ([15c06c5](AztecProtocol@15c06c5)) * Master ([AztecProtocol#4547](AztecProtocol#4547)) ([490ca26](AztecProtocol@490ca26)) * Mirror_noir_subrepo.yml ([AztecProtocol#4550](AztecProtocol#4550)) ([f8d8311](AztecProtocol@f8d8311)) * Mul with endomorphism ([AztecProtocol#4538](AztecProtocol#4538)) ([1f4c90d](AztecProtocol@1f4c90d)) * **noir-mirror:** Don't update .gitrepo on push ([AztecProtocol#4555](AztecProtocol#4555)) ([686140a](AztecProtocol@686140a)) * Recreate jest.config.ts for sequencer-client ([AztecProtocol#4553](AztecProtocol#4553)) ([d172f0b](AztecProtocol@d172f0b)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([AztecProtocol#4530](AztecProtocol#4530)) ([ce51d20](AztecProtocol@ce51d20)) * Use ordered-binary value encoding for multi maps ([AztecProtocol#4565](AztecProtocol#4565)) ([04ae0d2](AztecProtocol@04ae0d2)) ### Miscellaneous * Aligning some naming in `BaseOrMergeRollupPublicInputs` ([AztecProtocol#4510](AztecProtocol#4510)) ([47d66f9](AztecProtocol@47d66f9)) * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([AztecProtocol#4554](AztecProtocol#4554)) ([ca4dd60](AztecProtocol@ca4dd60)) * **avm-simulator:** Reduce boilerplate in AVM memory types ([AztecProtocol#4542](AztecProtocol#4542)) ([da2f5ed](AztecProtocol@da2f5ed)) * **avm:** Add/improve tests for AvmContext, tagged memory, etc ([AztecProtocol#4484](AztecProtocol#4484)) ([2fccdf2](AztecProtocol@2fccdf2)) * **avm:** Remove field support for comparators and bitwise ops ([AztecProtocol#4516](AztecProtocol#4516)) ([87a9663](AztecProtocol@87a9663)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([AztecProtocol#4502](AztecProtocol#4502)) ([bf4fc6c](AztecProtocol@bf4fc6c)), closes [AztecProtocol#4495](AztecProtocol#4495) * Cleanup of `abi.nr` in `aztec-nr` ([AztecProtocol#4473](AztecProtocol#4473)) ([6d9c73a](AztecProtocol@6d9c73a)) * Cleanup of `abi.nr` in `aztec-nr` (AztecProtocol#4473) [skip ci] ([db803bd](AztecProtocol@db803bd)) * Create constraints for sha256 compression opcode ([AztecProtocol#4503](AztecProtocol#4503)) ([64bef49](AztecProtocol@64bef49)) * Little cpp style improvements ([AztecProtocol#4528](AztecProtocol#4528)) ([dcc9ba4](AztecProtocol@dcc9ba4)) * Move noir out of yarn-project ([AztecProtocol#4479](AztecProtocol#4479)) ([1fe674b](AztecProtocol@1fe674b)), closes [AztecProtocol#4107](AztecProtocol#4107) * Pull noir ([AztecProtocol#4546](AztecProtocol#4546)) ([acf5cf2](AztecProtocol@acf5cf2)) * Pull noir (AztecProtocol#4546) ([db803bd](AztecProtocol@db803bd)) * Redo noir subrepo force push ([AztecProtocol#4514](AztecProtocol#4514)) ([7b519a4](AztecProtocol@7b519a4)) * Remove .oldValue in contract state update request ([AztecProtocol#4499](AztecProtocol#4499)) ([a796bef](AztecProtocol@a796bef)) * Removing redundant utilities ([AztecProtocol#4532](AztecProtocol#4532)) ([79bf445](AztecProtocol@79bf445)), closes [AztecProtocol#3470](AztecProtocol#3470) * Rename kernel circuits and disambiguate inputs ([AztecProtocol#4535](AztecProtocol#4535)) ([ed6d521](AztecProtocol@ed6d521)) * Replace relative paths to noir-protocol-circuits ([f1accbf](AztecProtocol@f1accbf)) * Replace relative paths to noir-protocol-circuits ([20ee430](AztecProtocol@20ee430)) * Replace relative paths to noir-protocol-circuits ([101ab59](AztecProtocol@101ab59)) * Simulator utils cleanup ([AztecProtocol#4507](AztecProtocol#4507)) ([1dd0ebf](AztecProtocol@1dd0ebf)) * Sync to noir-lang/noir ([db803bd](AztecProtocol@db803bd)) * Testing all values in `PublicGlobalVariables` and `PrivateGlobalVariables` ([AztecProtocol#4481](AztecProtocol#4481)) ([bc25f9b](AztecProtocol@bc25f9b)) * Testing historical header in contexts ([AztecProtocol#4509](AztecProtocol#4509)) ([c00229a](AztecProtocol@c00229a)) * Updating field conversion code without pointer hack ([AztecProtocol#4537](AztecProtocol#4537)) ([94f436e](AztecProtocol@94f436e)) * Uses sha256compression opcode in Noir and implements acvm solver for it ([AztecProtocol#4511](AztecProtocol#4511)) ([9dc05bc](AztecProtocol@9dc05bc)) ### Documentation * Describe the new message box model ([AztecProtocol#4485](AztecProtocol#4485)) ([14cc1dd](AztecProtocol@14cc1dd)) * Review of docs, so far ([AztecProtocol#4505](AztecProtocol#4505)) ([140c508](AztecProtocol@140c508)) * **yellowpaper:** Avm tree-access operations ([AztecProtocol#4552](AztecProtocol#4552)) ([913f4bd](AztecProtocol@913f4bd)) * **yellowpaper:** Separate section for AVM state ([AztecProtocol#4440](AztecProtocol#4440)) ([7881f09](AztecProtocol@7881f09)) </details> <details><summary>barretenberg.js: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg.js-v0.23.0...barretenberg.js-v0.24.0) (2024-02-13) ### Features * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) </details> <details><summary>barretenberg: 0.24.0</summary> ## [0.24.0](AztecProtocol/aztec-packages@barretenberg-v0.23.0...barretenberg-v0.24.0) (2024-02-13) ### Features * Add hashing to stdlib transcript ([AztecProtocol#4161](AztecProtocol#4161)) ([e78b86f](AztecProtocol@e78b86f)) * Added cast opcode and cast calldata ([AztecProtocol#4423](AztecProtocol#4423)) ([e58eda8](AztecProtocol@e58eda8)) * Enable gmock and upgrade gtest to 1.13 ([AztecProtocol#4480](AztecProtocol#4480)) ([5fc02e7](AztecProtocol@5fc02e7)) * IVC bench ([AztecProtocol#4515](AztecProtocol#4515)) ([d8ae42b](AztecProtocol@d8ae42b)) * Op count timers ([AztecProtocol#4471](AztecProtocol#4471)) ([26918de](AztecProtocol@26918de)) * PG + Goblin ([AztecProtocol#4399](AztecProtocol#4399)) ([295cd55](AztecProtocol@295cd55)) * Prototype native merkle trees ([AztecProtocol#4457](AztecProtocol#4457)) ([7d5e056](AztecProtocol@7d5e056)) ### Bug Fixes * Convert folding recursive verifier ops to batch mul ([AztecProtocol#4517](AztecProtocol#4517)) ([3750b26](AztecProtocol@3750b26)) * Cycle_group validate_is_on_curve bug ([AztecProtocol#4494](AztecProtocol#4494)) ([fecf3f7](AztecProtocol@fecf3f7)) * Mul with endomorphism ([AztecProtocol#4538](AztecProtocol#4538)) ([1f4c90d](AztecProtocol@1f4c90d)) * StandardCircuitBuilder create_logic_constraint and uint logic_operator ([AztecProtocol#4530](AztecProtocol#4530)) ([ce51d20](AztecProtocol@ce51d20)) ### Miscellaneous * **avm-circuit:** Tests use OpCode enum's instead of hardcoded values ([AztecProtocol#4554](AztecProtocol#4554)) ([ca4dd60](AztecProtocol@ca4dd60)) * **avm:** Use some matchers gtest functionalities to improve unit tests ([AztecProtocol#4502](AztecProtocol#4502)) ([bf4fc6c](AztecProtocol@bf4fc6c)), closes [AztecProtocol#4495](AztecProtocol#4495) * Create constraints for sha256 compression opcode ([AztecProtocol#4503](AztecProtocol#4503)) ([64bef49](AztecProtocol@64bef49)) * Little cpp style improvements ([AztecProtocol#4528](AztecProtocol#4528)) ([dcc9ba4](AztecProtocol@dcc9ba4)) * Updating field conversion code without pointer hack ([AztecProtocol#4537](AztecProtocol#4537)) ([94f436e](AztecProtocol@94f436e)) ### Documentation * **yellowpaper:** Avm tree-access operations ([AztecProtocol#4552](AztecProtocol#4552)) ([913f4bd](AztecProtocol@913f4bd)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

ludamad0 and others added 10 commits February 6, 2024 22:32

feat: op count timers

87b1340

fixes

20a1a1a

Merge branch 'ad/feat/op-count-timers' into infinity

4c9bcc5

checkpoint

834aa95

fix: batch mul

c9c1530

fix: mul_with_endo batched

ee4ed46

Update settings.json

1718e13

revert: timers

dd132fc

Merge remote-tracking branch 'origin/ad/fix/endo-infinite' into ad/fi…

4c31fc9

…x/endo-infinite

time

5c3783e

fix

9c08a58

ludamad force-pushed the ad/fix/endo-infinite branch from 069d6d5 to 9c08a58 Compare February 11, 2024 11:24

ludamad0 added 4 commits February 11, 2024 11:39

fix: gcc

9a28126

fix

2a38c9a

Merge remote-tracking branch 'origin/master' into ad/fix/endo-infinite

f1396c9

fix: inversion of 0 in the field

3aa3ce2

ludamad commented Feb 12, 2024

View reviewed changes

ludamad0 added 3 commits February 12, 2024 10:41

cleanup

b95502f

consistency

4313e8b

fix consistency pass

637c531

ludamad force-pushed the ad/fix/endo-infinite branch from 063a902 to 637c531 Compare February 12, 2024 10:51

ludamad and others added 5 commits February 12, 2024 06:29

Merge branch 'master' into ad/fix/endo-infinite

07c6c59

Merge branch 'master' into ad/fix/endo-infinite

58693b9

fix: master

a828c5b

Merge remote-tracking branch 'origin/fix/master' into ad/fix/endo-inf…

4bfd00b

…inite

Merge remote-tracking branch 'origin/ad/fix/endo-infinite' into ad/fi…

3347344

…x/endo-infinite

Rumata888 reviewed Feb 12, 2024

View reviewed changes

barretenberg/cpp/src/barretenberg/ecc/groups/affine_element.test.cpp Show resolved Hide resolved

Rumata888 reviewed Feb 12, 2024

View reviewed changes

Rumata888 approved these changes Feb 12, 2024

View reviewed changes

codygunton assigned ludamad Feb 12, 2024

ludamad0 and others added 3 commits February 12, 2024 15:19

fix: review feedback

2c2e5d3

Merge branch 'master' into ad/fix/endo-infinite

161262e

comment fix

f48445f

ludamad enabled auto-merge (squash) February 12, 2024 18:34

ludamad merged commit 1f4c90d into master Feb 12, 2024
83 of 85 checks passed

ludamad deleted the ad/fix/endo-infinite branch February 12, 2024 19:05

AztecBot mentioned this pull request Feb 12, 2024

chore(master): Release 0.24.0 #4491

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: mul with endomorphism #4538

fix: mul with endomorphism #4538

ludamad commented Feb 10, 2024 •

edited

Loading

AztecBot commented Feb 10, 2024 •

edited

Loading

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

ludamad Feb 12, 2024

Rumata888 Feb 12, 2024

ludamad Feb 12, 2024

ludamad Feb 12, 2024

Rumata888 Feb 12, 2024

Rumata888 Feb 12, 2024 •

edited

Loading

Rumata888 Feb 12, 2024

Rumata888 Feb 12, 2024 •

edited

Loading

ludamad Feb 12, 2024

Rumata888 left a comment

fix: mul with endomorphism #4538

fix: mul with endomorphism #4538

Conversation

ludamad commented Feb 10, 2024 • edited Loading

AztecBot commented Feb 10, 2024 • edited Loading

Benchmark results

L2 block published to L1

L2 chain processing

Circuits stats

Tree insertion stats

Miscellaneous

ludamad Feb 12, 2024

Choose a reason for hiding this comment

Rumata888 Feb 12, 2024

Choose a reason for hiding this comment

ludamad Feb 12, 2024

Choose a reason for hiding this comment

ludamad Feb 12, 2024

Choose a reason for hiding this comment

Rumata888 Feb 12, 2024

Choose a reason for hiding this comment

Rumata888 Feb 12, 2024 • edited Loading

Choose a reason for hiding this comment

Rumata888 Feb 12, 2024

Choose a reason for hiding this comment

Rumata888 Feb 12, 2024 • edited Loading

Choose a reason for hiding this comment

ludamad Feb 12, 2024

Choose a reason for hiding this comment

Rumata888 left a comment

Choose a reason for hiding this comment

ludamad commented Feb 10, 2024 •

edited

Loading

AztecBot commented Feb 10, 2024 •

edited

Loading

Rumata888 Feb 12, 2024 •

edited

Loading

Rumata888 Feb 12, 2024 •

edited

Loading