Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nargo fmt #6169

Closed
wants to merge 1 commit into from
Closed

fix: nargo fmt #6169

wants to merge 1 commit into from

Conversation

LHerskind
Copy link
Contributor

@LHerskind LHerskind commented May 3, 2024

Ran nargo fmt.

Copy link
Contributor Author

LHerskind commented May 3, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @LHerskind and the rest of your teammates on Graphite Graphite

@LHerskind LHerskind marked this pull request as ready for review May 3, 2024 08:37
@benesjan benesjan enabled auto-merge (squash) May 3, 2024 09:18
@benesjan benesjan force-pushed the lh/run-nargo-fmt-1 branch from 0e97c75 to 3270ba2 Compare May 3, 2024 11:09
@TomAFrench
Copy link
Member

btw, we have nargo fmt --check which works as a CI check for this. You could add an earthly target for this to enforce this going forwards.

@LHerskind
Copy link
Contributor Author

btw, we have nargo fmt --check which works as a CI check for this. You could add an earthly target for this to enforce this going forwards.

While we got you here @TomAFrench.
Running nargo fmt can cause a failure in tests where we are expecting certain error messages as it changes due to the formatting. Example:
image

@TomAFrench
Copy link
Member

This looks like more of an artifact of aztec's own simulator's error logic to me.

getMessage() {
if (this.noirErrorStack && !isNoirCallStackUnresolved(this.noirErrorStack) && this.noirErrorStack.length) {
return `${this.originalMessage} '${this.noirErrorStack[this.noirErrorStack.length - 1].locationText}'`;
}
return this.originalMessage;
}

@benesjan benesjan force-pushed the lh/run-nargo-fmt-1 branch from a96a547 to 493a8f7 Compare May 3, 2024 11:57
@LHerskind LHerskind force-pushed the lh/run-nargo-fmt-1 branch from 3d4d3e4 to a21ac88 Compare May 3, 2024 13:58
@benesjan
Copy link
Contributor

benesjan commented May 3, 2024

Closed in favor of #6184 as @LHerskind absolutely refuses to let this one in 😆
image

@benesjan benesjan closed this May 3, 2024
auto-merge was automatically disabled May 3, 2024 14:02

Pull request was closed

@ludamad ludamad deleted the lh/run-nargo-fmt-1 branch August 22, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants