Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ALU pil relation TWO_LINE_OP_NO_OVERLAP #6968

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fix: ALU pil relation TWO_LINE_OP_NO_OVERLAP #6968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion barretenberg/cpp/pil/avm/avm_alu.pil
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,7 +514,7 @@ namespace avm_alu(256);
// 128-bit multiplication and CAST need two rows in ALU trace. We need to ensure
// that another ALU operation does not start in the second row.
#[TWO_LINE_OP_NO_OVERLAP]
(op_mul * ff_tag + op_cast) * alu_sel' = 0;
(op_mul * u128_tag + op_cast) * alu_sel' = 0;

// ========= SHIFT LEFT/RIGHT OPERATIONS ===============================
// Given (1) an input b, within the range [0, 2**128-1],
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/relations/generated/avm/avm_alu.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,7 +903,7 @@ template <typename FF_> class avm_aluImpl {
{
Avm_DECLARE_VIEWS(54);

auto tmp = (((avm_alu_op_mul * avm_alu_ff_tag) + avm_alu_op_cast) * avm_alu_alu_sel_shift);
auto tmp = (((avm_alu_op_mul * avm_alu_u128_tag) + avm_alu_op_cast) * avm_alu_alu_sel_shift);
tmp *= scaling_factor;
std::get<54>(evals) += tmp;
}
Expand Down
21 changes: 8 additions & 13 deletions barretenberg/cpp/src/barretenberg/vm/generated/avm_verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,7 +745,6 @@ bool AvmVerifier::verify_proof(const HonkProof& proof, const std::vector<std::ve

// If Sumcheck did not verify, return false
if (sumcheck_verified.has_value() && !sumcheck_verified.value()) {
info("failed sumcheck");
return false;
}

Expand All @@ -754,31 +753,27 @@ bool AvmVerifier::verify_proof(const HonkProof& proof, const std::vector<std::ve
FF avm_kernel_kernel_inputs__is_public_evaluation =
evaluate_public_input_column(public_inputs[0], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_inputs__is_public_evaluation != claimed_evaluations.avm_kernel_kernel_inputs__is_public) {
info("failed kernel inputs public inputs");
return false;
}

FF avm_kernel_kernel_value_out__is_public_evaluation =
evaluate_public_input_column(public_inputs[1], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_value_out__is_public_evaluation !=
claimed_evaluations.avm_kernel_kernel_value_out__is_public) {
info("failed value out inputs");
FF avm_kernel_kernel_metadata_out__is_public_evaluation =
evaluate_public_input_column(public_inputs[3], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_metadata_out__is_public_evaluation !=
claimed_evaluations.avm_kernel_kernel_metadata_out__is_public) {
return false;
}

FF avm_kernel_kernel_side_effect_out__is_public_evaluation =
evaluate_public_input_column(public_inputs[2], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_side_effect_out__is_public_evaluation !=
claimed_evaluations.avm_kernel_kernel_side_effect_out__is_public) {
info("failed side effect inputs");
return false;
}

FF avm_kernel_kernel_metadata_out__is_public_evaluation =
evaluate_public_input_column(public_inputs[3], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_metadata_out__is_public_evaluation !=
claimed_evaluations.avm_kernel_kernel_metadata_out__is_public) {
info("failed kernel metadata inputs");
FF avm_kernel_kernel_value_out__is_public_evaluation =
evaluate_public_input_column(public_inputs[1], circuit_size, multivariate_challenge);
if (avm_kernel_kernel_value_out__is_public_evaluation !=
claimed_evaluations.avm_kernel_kernel_value_out__is_public) {
return false;
}

Expand Down
Loading