Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use result key #7267

Merged
merged 1 commit into from
Jul 2, 2024
Merged

fix: use result key #7267

merged 1 commit into from
Jul 2, 2024

Conversation

spypsy
Copy link
Member

@spypsy spypsy commented Jul 2, 2024

Please read contributing guidelines and remove this line.

@spypsy spypsy marked this pull request as ready for review July 2, 2024 10:16
@spypsy spypsy merged commit 1227447 into devnet Jul 2, 2024
3 checks passed
@spypsy spypsy deleted the devnet-redeploy-5 branch July 2, 2024 10:17
@AztecBot
Copy link
Collaborator

AztecBot commented Jul 2, 2024

Benchmark results

Metrics with a significant change:

  • avm_simulation_time_ms (Token:mint_public): 69.0 (-89%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 236 (+227%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_30_ms 11,728 (-2%) 3,133 (-2%) 1,533 (-11%) 1,455 1,568 (+1%)
proof_construction_time_sha256_100_ms 43,844 (-1%) 11,799 (-1%) 5,444 5,390 (-1%) 5,365
proof_construction_time_poseidon_hash_ms 77.0 (-3%) 34.0 (-26%) 34.0 (-3%) 58.0 (-2%) 88.0
proof_construction_time_poseidon_hash_30_ms 1,516 (-1%) 418 202 (+2%) 222 (-3%) 265 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,758 (-1%) 1,579 (-1%) 728 795 801 (+1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 1,412 1,412 1,412
l1_rollup_calldata_gas 9,476 9,468 9,464
l1_rollup_execution_gas 610,297 610,289 610,285
l2_block_processing_time_in_ms 748 (-1%) 1,414 (-1%) 2,687 (-2%)
l2_block_building_time_in_ms 25,399 (-1%) 50,885 99,830
l2_block_rollup_simulation_time_in_ms 25,399 (-1%) 50,884 99,830
l2_block_public_tx_process_time_in_ms 21,832 (-1%) 47,112 96,082

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 7,016 (-1%) 9,955
node_database_size_in_bytes 12,152,912 16,105,552
pxe_database_size_in_bytes 16,254 26,813

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms proving_time_in_ms input_size_in_bytes output_size_in_bytes proof_size_in_bytes num_public_inputs size_in_gates
private-kernel-init 130 (-1%) 478 12,881 (-1%) 20,634 67,190 92,352 2,819 524,288
private-kernel-inner 393 1,057 (+12%) 49,544 (-1%) 94,902 67,190 92,352 2,819 2,097,152
private-kernel-tail 372 1,837 50,235 (-1%) 99,121 71,733 14,912 399 2,097,152
base-parity 6.24 (+1%) 1,908 (-2%) 2,863 (+5%) 128 64.0 2,208 2.00 131,072
root-parity 48.8 72.9 (-1%) 43,458 27,100 64.0 2,720 18.0 2,097,152
base-rollup 7,914 5,049 (+2%) 87,811 (-3%) 170,330 756 3,648 47.0 4,194,304
root-rollup 110 85.6 (-3%) 23,397 (+6%) 25,309 620 3,456 41.0 1,048,576
public-kernel-setup 716 3,735 45,459 116,905 93,334 125,344 3,850 2,097,152
public-kernel-app-logic 614 4,773 47,224 116,905 93,334 125,344 3,850 2,097,152
public-kernel-tail 1,412 40,366 (+6%) 196,391 (+1%) 511,910 10,014 14,912 399 8,388,608
private-kernel-reset-small 595 1,986 (-6%) 46,380 (-1%) 123,313 67,190 92,352 2,819 2,097,152
public-kernel-teardown 619 (+1%) 4,753 (+1%) 48,429 (+3%) 116,905 93,334 125,344 3,850 2,097,152
merge-rollup 28.8 N/A N/A 16,542 756 N/A N/A N/A
private-kernel-tail-to-public N/A 7,881 (+3%) 99,495 (-1%) N/A N/A 125,344 3,850 4,194,304

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms proof_size_in_bytes proving_time_in_ms size_in_gates num_public_inputs
ContractClassRegisterer:register 1,344 9,944 424 N/A N/A N/A N/A
ContractInstanceDeployer:deploy 1,408 9,944 39.7 N/A N/A N/A N/A
MultiCallEntrypoint:entrypoint 1,920 9,944 1,785 N/A N/A N/A N/A
GasToken:deploy 1,376 9,944 981 (-1%) N/A N/A N/A N/A
SchnorrAccount:constructor 1,312 9,944 1,419 N/A N/A N/A N/A
SchnorrAccount:entrypoint 2,304 9,944 2,830 16,768 54,715 (-1%) 2,097,152 457
Token:privately_mint_private_note 1,280 9,944 1,621 (-3%) N/A N/A N/A N/A
FPC:fee_entrypoint_public 1,344 9,944 363 (+3%) 16,768 11,324 (+1%) 524,288 457
Token:transfer 1,312 9,944 4,498 16,768 45,686 (-5%) 2,097,152 457
AuthRegistry:set_authorized (avm) 21,043 N/A N/A 87,200 1,436 (+6%) N/A N/A
FPC:prepare_fee (avm) 28,521 N/A N/A 88,032 5,890 (-1%) N/A N/A
AuthRegistry:consume (avm) 34,973 N/A N/A 87,616 3,073 (+1%) N/A N/A
Token:transfer_public (avm) 44,849 N/A N/A 87,616 3,269 (+7%) N/A N/A
FPC:pay_refund (avm) 33,381 N/A N/A 88,448 11,576 N/A N/A
Benchmarking:create_note 1,344 9,944 1,405 N/A N/A N/A N/A
SchnorrAccount:verify_private_authwit 1,280 9,944 73.2 N/A N/A N/A N/A
Token:unshield 1,376 9,944 3,690 N/A N/A N/A N/A
FPC:fee_entrypoint_private 1,376 9,944 4,626 N/A N/A N/A N/A

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
GasToken:_increase_public_balance 70.9 (-2%) 13,873
GasToken:set_portal 16.5 (-2%) 3,495
Token:constructor 94.5 (+2%) 24,207
FPC:constructor 67.0 (+5%) 13,893
GasToken:mint_public 52.6 (+3%) 10,241
Token:mint_public ⚠️ 69.0 (-89%) 19,216
Token:assert_minter_and_mint ⚠️ 236 (+227%) 13,034
AuthRegistry:set_authorized 31.7 (+2%) 7,869
FPC:prepare_fee 188 (+4%) 15,187
Token:transfer_public 51.1 (-15%) 31,425
FPC:pay_refund 125 (+1%) 20,080
Benchmarking:increment_balance 2,696 15,465
Token:_increase_public_balance 56.2 (-1%) 15,089
FPC:pay_refund_with_shielded_rebate 149 (-1%) 21,167

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.165 (+8%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 10.4 16.8 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.8 31.7 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.599 0.515 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 48.6 (+1%) 75.7 (-1%) 131 245 470 (-1%)
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.497 (+1%) 0.465 0.450 0.444 0.439 (-1%)
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 59.8 111 (-1%) 183 353 693 (-1%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 355 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.507 (+1%) 0.501 0.484 0.478 0.476 (-1%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 72.9 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 133 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.519 N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 85,672 670,983

Transaction size based on fee payment method

| Metric | |
| - | |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants