Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: commonly occurring typo #7807

Merged
merged 1 commit into from
Aug 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3,446 changes: 1,723 additions & 1,723 deletions .github/cache-success/restore-dist/index.js

Large diffs are not rendered by default.

3,446 changes: 1,723 additions & 1,723 deletions .github/cache-success/save-dist/index.js

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,7 @@ INLINE void hasher_merge_cv_stack(blake3_hasher* self, uint64_t total_len)
// of the whole tree, and it would need to be ROOT finalized. We can't
// compress it until we know.
// 2) This 64 KiB input might complete a larger tree, whose root node is
// similarly going to be the the root of the whole tree. For example, maybe
// similarly going to be the root of the whole tree. For example, maybe
// we have 196 KiB (that is, 128 + 64) hashed so far. We can't compress the
// node at the root of the 256 KiB subtree until we know how to finalize it.
//
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ namespace bb::crypto::merkle_tree {
using index_t = uint256_t;

/**
* @brief Used in parallel insertions in the the IndexedTree. Workers signal to other following workes as they move up
* @brief Used in parallel insertions in the IndexedTree. Workers signal to other following workes as they move up
* the level of the tree.
*
*/
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/eccvm/eccvm_flavor.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ class ECCVMFlavor {
};

/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ template <typename BuilderType> class ECCVMRecursiveFlavor_ {

using VerifierCommitmentKey = bb::VerifierCommitmentKey<Curve>;
/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witness)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witness)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to
Expand Down
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/polynomials/univariate.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,7 @@ template <class Fr, size_t domain_end, size_t domain_start = 0, size_t skip_coun
term *= Data::precomputed_denominator_inverses[LENGTH * k + j];
result.value_at(k) += term;
}
// scale the sum by the the value of of B(x)
// scale the sum by the value of of B(x)
result.value_at(k) *= Data::full_numerator_values[k];
}
}
Expand Down Expand Up @@ -497,7 +497,7 @@ template <class Fr, size_t domain_end, size_t domain_start = 0, size_t skip_coun
term *= denominator_inverses[i - domain_start];
result += term;
}
// scale the sum by the the value of of B(x)
// scale the sum by the value of of B(x)
result *= full_numerator_value;
return result;
};
Expand Down
4 changes: 2 additions & 2 deletions barretenberg/cpp/src/barretenberg/smt_verification/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ To store it on the disk just do the following
- ```smt_circuit::StandardCircuit circuit(CircuitSchema c_info, Solver* s, TermType type, str tag="", bool optimizations=true)```
- ```smt_circuit::UltraCircuit circuit(CircuitSchema c_info, Solver* s, TermType type, str tag="", bool optimizations=true)```

It will generate all the symbolic values of the circuit wires, add all the gate constrains, create a map `term_name->STerm` and the inverse of it. Where `term_name` is the the name you provided earlier.
It will generate all the symbolic values of the circuit wires, add all the gate constrains, create a map `term_name->STerm` and the inverse of it. Where `term_name` is the name you provided earlier.

In case you want to create two similar circuits with the same `solver` and `schema`, then you should specify the `tag`(name) of a circuit.

Expand Down Expand Up @@ -209,7 +209,7 @@ Another one is
- `pair<StandardCircuit, StandardCircuit> StandardCircuit::unique_witness_ext(CircuitSchema circuit_info, Solver* s, TermType type, vector<str> equal_variables, vector<str> nequal_variables, vector<str> at_least_one_equal_variable, vector<str> at_least_one_nequal_variable)` that does the same but provides you with more flexible settings.
- Same in `UltraCircuit`

The return circuits can be useful, if you want to define some additional constraints, that are not covered by the the above functions.
The return circuits can be useful, if you want to define some additional constraints, that are not covered by the above functions.
You can call `s.check`, `s.model`, `smt_timer` or `default_model` further.

## 5. smt_util.hpp
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ bool_t<Builder> ecdsa_verify_signature(const stdlib::byte_array<Builder>& messag
* It is used to recover signing public key from an ecdsa signature. In practice, the value
* of v is offset by 27 following the convention from the original bitcoin whitepaper.
*
* The value of v depends on the the point R = (x, y) s.t. r = x % |Fr|
* The value of v depends on the point R = (x, y) s.t. r = x % |Fr|
* 0: y is even && x < |Fr| (x = r)
* 1: y is odd && x < |Fr| (x = r)
* 2: y is even && |Fr| <= x < |Fq| (x = r + |Fr|)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ enum blake2s_constant {
* h: A 64-byte chain value denoted decomposed as (h_0, h_1, ..., h_7), each h_i is a 32-bit number.
* It form the first two rows on the internal state matrix v of the compression function G.
*
* t: It is a counter (t_0 lsb and t_1 msb) used in the the initialization of the internal state v.
* t: It is a counter (t_0 lsb and t_1 msb) used in the initialization of the internal state v.
*
* f: f_0 and f_1 are finalization flags used in the initialization of the internal state v.
* / 0xfff...ff if the block processed is the last
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ void bigfield<Builder, T>::perform_reductions_for_mult_madd(std::vector<bigfield
max_values_right[i] = mul_right[i].get_maximum_value();
}

// Sort the the vector
// Sort the vector
std::sort(maximum_value_updates.begin(), maximum_value_updates.end(), compare_update_tuples);
}
// Now we have reduced everything exactly to the point of no overflow. There is probably a way to use even
Expand Down Expand Up @@ -2700,7 +2700,7 @@ void bigfield<Builder, T>::unsafe_evaluate_multiple_multiply_add(const std::vect
ctx->decompose_into_default_range(carry_lo.witness_index, static_cast<size_t>(carry_lo_msb));
ctx->decompose_into_default_range(carry_hi.witness_index, static_cast<size_t>(carry_hi_msb));
}
was removed from the the `else` block below. See the conversation at
was removed from the `else` block below. See the conversation at
https://github.com/AztecProtocol/aztec2-internal/pull/1023
We should make sure that no constraint like this is needed but missing (e.g., an equivalent constraint
was just imposed?). */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ TEST(stdlib_plookup, blake2s_xor_rotate_16)
}

/*
* The following out coefficients are the the ones multiplied for computing the cumulative intermediate terms
* The following out coefficients are the ones multiplied for computing the cumulative intermediate terms
* in the expected output. If the column_3_coefficients for this table are (a0, a1, ..., a5), then the
* out_coefficients must be (a5/a4, a4/a3, a3/a2, a2/a1, a1/a0). Note that these are stored in reverse orde
* for simplicity.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1705,7 +1705,7 @@ template <typename Builder> class stdlib_uint : public testing::Test {
}

/**
* @brief Test the the function uint_ct::at used to extract bits.
* @brief Test the function uint_ct::at used to extract bits.
*/
static void test_at()
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ class MegaFlavor {
};

/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to resolve
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ template <typename BuilderType> class MegaRecursiveFlavor_ {
using Base::Base;
};
/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to resolve
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ void UltraCircuitBuilder_<Arithmetization>::create_poly_gate(const poly_triple_<
*
* @details x and y are defined over scalar field.
*
* @param in Elliptic curve point addition gate parameters, including the the affine coordinates of the two points being
* @param in Elliptic curve point addition gate parameters, including the affine coordinates of the two points being
* added, the resulting point coordinates and the selector values that describe whether the second point is negated.
*/
template <typename Arithmetization>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ class UltraFlavor {
};

/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to resolve
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ class UltraKeccakFlavor {
};

/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to resolve
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ template <typename BuilderType> class UltraRecursiveFlavor_ {

public:
/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to resolve
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -843,7 +843,7 @@ class TranslatorFlavor {
};

/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ template <typename BuilderType> class TranslatorRecursiveFlavor_ {
using Base::Base;
};
/**
* @brief The verification key is responsible for storing the the commitments to the precomputed (non-witnessk)
* @brief The verification key is responsible for storing the commitments to the precomputed (non-witnessk)
* polynomials used by the verifier.
*
* @note Note the discrepancy with what sort of data is stored here vs in the proving key. We may want to
Expand Down
2 changes: 1 addition & 1 deletion barretenberg/cpp/src/barretenberg/vm/avm/trace/trace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2760,7 +2760,7 @@ void AvmTraceBuilder::op_call(uint8_t indirect,
{ hint.success });
external_call_counter++;
pc++;
// Adjust the side_effect_counter to the the value at the end of the external call.
// Adjust the side_effect_counter to the value at the end of the external call.
side_effect_counter = static_cast<uint32_t>(hint.end_side_effect_counter);
}

Expand Down
2 changes: 1 addition & 1 deletion barretenberg/ts/scripts/build_wasm.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ fi
# We only need the threads wasm, as node always uses threads.
# We need to take two copies for both esm and cjs builds. You can't use symlinks when publishing.
# This probably isn't a big deal however due to compression.
# When building the the browser bundle, both wasms are inlined directly.
# When building the browser bundle, both wasms are inlined directly.
mkdir -p ./dest/node/barretenberg_wasm
mkdir -p ./dest/node-cjs/barretenberg_wasm
cp ../cpp/build-wasm-threads/bin/barretenberg.wasm ./dest/node/barretenberg_wasm/barretenberg-threads.wasm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Allows a recipient to consume a message from the `Outbox`.
- Will revert with `Outbox__InvalidChainId()` if `block.chainid != _message.recipient.chainId`.
- Will revert with `Outbox__NothingToConsumeAtBlock(uint256 l2BlockNumber)` if the root for the block has not been set yet.
- Will revert with `Outbox__AlreadyNullified(uint256 l2BlockNumber, uint256 leafIndex)` if the message at leafIndex for the block has already been consumed.
- Will revert with `Outbox__InvalidPathLength(uint256 expected, uint256 actual)` if the the supplied height is less than the existing minimum height of the L2 to L1 message tree, or the supplied height is greater than the maximum (minimum height + log2(maximum messages)).
- Will revert with `Outbox__InvalidPathLength(uint256 expected, uint256 actual)` if the supplied height is less than the existing minimum height of the L2 to L1 message tree, or the supplied height is greater than the maximum (minimum height + log2(maximum messages)).
- Will revert with `MerkleLib__InvalidRoot(bytes32 expected, bytes32 actual, bytes32 leaf, uint256 leafIndex)` if unable to verify the message existence in the tree. It returns the message as a leaf, as well as the index of the leaf to expose more info about the error.


Expand Down
4 changes: 2 additions & 2 deletions noir-projects/aztec-nr/authwit/src/auth.nr
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ pub fn assert_current_call_valid_authwit_public(context: &mut PublicContext, on_
* Note that the authentication registry will take the `msg_sender` into account as the consumer, so this will only
* work if the `msg_sender` is the same as the `consumer` when the `message_hash` was inserted into the registry.
*
* @param on_behalf_of The address that have authorized the the `inner_hash`
* @param on_behalf_of The address that have authorized the `inner_hash`
*/
pub fn assert_inner_hash_valid_authwit_public(context: &mut PublicContext, on_behalf_of: AztecAddress, inner_hash: Field) {
let result: Field = context.call_public_function(
Expand Down Expand Up @@ -316,7 +316,7 @@ pub fn compute_inner_authwit_hash<let N: u32>(args: [Field; N]) -> Field {
*
* Using the `on_behalf_of` and the `inner_hash` to ensure that the nullifier is siloed for a specific `on_behalf_of`.
*
* @param on_behalf_of The address that have authorized the the `inner_hash`
* @param on_behalf_of The address that have authorized the `inner_hash`
* @param inner_hash The hash of the message to authorize
*/
pub fn compute_authwit_nullifier(on_behalf_of: AztecAddress, inner_hash: Field) -> Field {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl<T> BalancesMap<T, &mut PrivateContext> {
let note = notes.get_unchecked(i);

// Removes the note from the owner's set of notes.
// This will call the the `compute_nullifer` function of the `token_note`
// This will call the `compute_nullifer` function of the `token_note`
// which require knowledge of the secret key (currently the users encryption key).
// The contract logic must ensure that the spending key is used as well.
// docs:start:remove
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ impl<T> BalancesMap<T, &mut PrivateContext> {
let note = notes.get_unchecked(i);

// Removes the note from the owner's set of notes.
// This will call the the `compute_nullifer` function of the `token_note`
// This will call the `compute_nullifer` function of the `token_note`
// which require knowledge of the secret key (currently the users encryption key).
// The contract logic must ensure that the spending key is used as well.
// docs:start:remove
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ impl<T> BalancesMap<T, &mut PrivateContext> {
let note = notes.get_unchecked(i);

// Removes the note from the owner's set of notes.
// This will call the the `compute_nullifer` function of the `token_note`
// This will call the `compute_nullifer` function of the `token_note`
// which require knowledge of the secret key (currently the users encryption key).
// The contract logic must ensure that the spending key is used as well.
// docs:start:remove
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export class BlockBodyStore {

/**
* Gets an L2 block body.
* @param txsEffectsHash - The txHash of the the block body to return
* @param txsEffectsHash - The txHash of the block body to return
* @returns The requested L2 block body
*/
getBlockBody(txsEffectsHash: Buffer): Body | undefined {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class MemoryArchiverStore implements ArchiverDataStore {
private l2BlockBodies: Map<string, Body> = new Map();

/**
* An array containing all the the tx effects in the L2 blocks that have been fetched so far.
* An array containing all the tx effects in the L2 blocks that have been fetched so far.
*/
private txEffects: TxEffect[] = [];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export abstract class L1Payload {

/**
* Encrypts an event payload for a given recipient and sender.
* Creates an incoming log the the recipient using the recipient's ivsk, and
* Creates an incoming log the recipient using the recipient's ivsk, and
* an outgoing log for the sender using the sender's ovsk.
*
* @param ephSk - An ephemeral secret key used for the encryption
Expand Down
2 changes: 1 addition & 1 deletion yarn-project/key-store/src/key_store.ts
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ export class KeyStore {
* Gets the key validation request for a given master public key hash and contract address.
* @throws If the account corresponding to the master public key hash does not exist in the key store.
* @param pkMHash - The master public key hash.
* @param contractAddress - The contract address to silo the secret key in the the key validation request with.
* @param contractAddress - The contract address to silo the secret key in the key validation request with.
* @returns The key validation request.
*/
public getKeyValidationRequest(pkMHash: Fr, contractAddress: AztecAddress): Promise<KeyValidationRequest> {
Expand Down
Loading