feat: sequencer is aware of slot progression #9767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-mitch
added
e2e-all
Maddiaa0
reviewed
Nov 6, 2024
|
|
||
| /** | ||
| * The maximum number of seconds that the sequencer can be into a slot to transition to a particular state. | ||
| * For example, in order to transition into WAITING_FOR_ATTESTATIONS, the sequencer can be at most 3 seconds into the slot. |
There was a problem hiding this comment.
Should the 4 here be set to the config value of max transactions per block?
There was a problem hiding this comment.
Great call. I also had it check that max time needed as a result of the config is less than the slot length.
Also I gated functionality behind and env var SEQ_ENFORCE_TIME_TABLE, which is now enabled by default in the helm chart values, and it passed the reorg test 🔥
Maddiaa0
reviewed
Nov 6, 2024
| @@ -312,7 +313,7 @@ export class Sequencer { | |||
| throw new Error(msg); | |||
| } | |||
|
|
|||
| this.log.debug(`Can propose block ${proposalBlockNumber} at slot ${slot}`); | |||
| this.log.info(`Can propose block ${proposalBlockNumber} at slot ${slot}`); | |||
Maddiaa0
approved these changes
Nov 6, 2024
add metrics on time to spare between state transitions
just-mitch
force-pushed
the
mt/sequencer-is-aware-of-slot-progression
branch
from
b2f1fa3 to
ea41835
Compare
just-mitch
removed
e2e-all
just-mitch
added a commit
that referenced
this pull request
Nov 6, 2024
This reverts commit 86762a1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sequencer now has explicit timeliness requirements for itself with respect to block building.
We also log a metric for the amount of time left (or overconsumed) when trying to transition from one state to the next.
Also fix a bug where we could permanently fail to build any blocks if our publish failed.