Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Translator relations #1128

Closed
Rumata888 opened this issue Oct 9, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9251
Closed

Fix Translator relations #1128

Rumata888 opened this issue Oct 9, 2024 · 0 comments · Fixed by AztecProtocol/aztec-packages#9251
Assignees
Labels
bug Something isn't working

Comments

@Rumata888
Copy link
Contributor

Since we are not going to be doing degree checks on translator polynomials in the mini circuit, we have to add relations ensuring range constraint wires are zeroed out outside of the mini circuit (should be 64 2-degree equations which can be skipped almost all the time)

@Rumata888 Rumata888 added the bug Something isn't working label Oct 9, 2024
@Rumata888 Rumata888 self-assigned this Oct 9, 2024
Rumata888 added a commit to AztecProtocol/aztec-packages that referenced this issue Oct 31, 2024
…ide of minicircuit (#9251)

When Translator was built, there was expectation on using ZM's degree
checks for minicircuit polynomials later. ZM is dead, so we have to
enforce those in another way so there is no soundness issue during
polynomial concatenation. This PR adds relations to ensure
range_constraint polynomials are zero outside of minicircuit

ClientIVC before:

![image](https://github.com/user-attachments/assets/6299f04b-41de-4f41-90e4-45e49bf42470)
ClientIVC after:

![image](https://github.com/user-attachments/assets/5b0c8677-ee3f-4195-898e-892ef38e9eef)

Fixes AztecProtocol/barretenberg#1128
AztecBot pushed a commit that referenced this issue Nov 1, 2024
…ide of minicircuit (#9251)

When Translator was built, there was expectation on using ZM's degree
checks for minicircuit polynomials later. ZM is dead, so we have to
enforce those in another way so there is no soundness issue during
polynomial concatenation. This PR adds relations to ensure
range_constraint polynomials are zero outside of minicircuit

ClientIVC before:

![image](https://github.com/user-attachments/assets/6299f04b-41de-4f41-90e4-45e49bf42470)
ClientIVC after:

![image](https://github.com/user-attachments/assets/5b0c8677-ee3f-4195-898e-892ef38e9eef)

Fixes #1128
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant