Uniformize handling of public inputs block #1220
Assignees
Comments
ledwards2225
added a commit
to AztecProtocol/aztec-packages
that referenced
this issue
Feb 8, 2025
Simplifies handling of public inputs by populating `pub_inputs` block in `finalize_circuit()` which ensures that all blocks are complete prior to any prover work. Also improves some of the log info related to the overflow mechanism. closes: AztecProtocol/barretenberg#1220
AztecBot
pushed a commit
that referenced
this issue
Feb 9, 2025
Simplifies handling of public inputs by populating `pub_inputs` block in `finalize_circuit()` which ensures that all blocks are complete prior to any prover work. Also improves some of the log info related to the overflow mechanism. closes: #1220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
pub_inputsblock is a special case in that it is not populated directly by the circuit builder like the other blocks. (This has led to some more complex than necessary handling of the PI in the prover. It has also led to a gap in error handling for the case where the number of public inputs exceeds the fixed capacity in the structured setting. One way to resolve this may be to have the builder populate the public inputs. Otherwise, simply ensure that there is a clear warning.The text was updated successfully, but these errors were encountered: