Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor for bun, viem, and other things #82

Merged
merged 15 commits into from
Jul 23, 2024
Merged

Conversation

signorecello
Copy link
Collaborator

@signorecello signorecello commented Jun 13, 2024

Description

  • Moved to bun because it's faster, works great with typescript out of the box, has a test runner, it's just goodness.
  • Used a lot more of hardhat's capabilities, namely tasks, config vars instead of environment vars, etc
  • Removed the need to have nargo installed by using bb directly, this makes everything run programatically!
  • Since I was there, did the same for vite, no more command line for vite
  • Updated to the latest viem and pinned that version
  • Added a button so users can decide to not verify the proof on-chain

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for noir-vite-hardhat ready!

Name Link
🔨 Latest commit f8430df
🔍 Latest deploy log https://app.netlify.com/sites/noir-vite-hardhat/deploys/669f8aa336878100084badee
😎 Deploy Preview https://deploy-preview-82--noir-vite-hardhat.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

socket-security bot commented Jun 13, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@noir-lang/[email protected] Transitive: environment, filesystem, shell +6 144 MB noir-lang
npm/@noir-lang/[email protected] Transitive: eval, filesystem, network +2 9.36 MB noir-lang
npm/@noir-lang/[email protected] None +1 27.1 MB noir-lang
npm/@noir-lang/[email protected] None 0 50.1 kB noir-lang
npm/@nomicfoundation/[email protected] Transitive: environment, filesystem, network +19 21.4 MB kanej
npm/@nomicfoundation/[email protected] Transitive: environment, filesystem, network +13 21.3 MB schaable
npm/@nomicfoundation/[email protected] Transitive: environment, filesystem +39 5.85 MB kanej
npm/@nomicfoundation/[email protected] environment +6 22 MB kanej
npm/@nomicfoundation/[email protected] environment Transitive: eval, network, unsafe +50 5.87 MB kanej
npm/@nomicfoundation/[email protected] filesystem +3 40.5 MB schaable
npm/@tanstack/[email protected] environment +1 3.04 MB tannerlinsley
npm/@types/[email protected] None 0 95.9 kB types
npm/@types/[email protected] None 0 1.97 MB types
npm/@types/[email protected] None +2 1.69 MB types
npm/@vitejs/[email protected] filesystem, unsafe Transitive: environment, shell +13 439 MB vitebot
npm/[email protected] environment 0 186 kB abetomo
npm/[email protected] environment, filesystem 0 79.1 kB motdotla
npm/[email protected] environment, filesystem, network, shell Transitive: eval, unsafe +220 165 MB alcuadrado
npm/[email protected] environment +3 4.63 MB react-bot
npm/[email protected] environment +2 339 kB react-bot
npm/[email protected] environment, filesystem Transitive: eval, network, unsafe +182 27 MB cgewecke
npm/[email protected] network Transitive: environment, filesystem +10 15.5 MB awkweb, jmoxey
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +47 274 MB vitebot
npm/[email protected] Transitive: environment, eval, filesystem, network, unsafe +265 157 MB awkweb

🚮 Removed packages: npm/@aztec/[email protected], npm/@babel/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@chainsafe/[email protected], npm/@coinbase/[email protected], npm/@discoveryjs/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@esbuild/[email protected], npm/@fastify/[email protected], npm/@ioredis/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@jridgewell/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@motionone/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@noir-lang/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@nomicfoundation/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@parcel/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@rollup/[email protected], npm/@safe-global/[email protected], npm/@scure/[email protected], npm/@socket.io/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@swc/[email protected], npm/@tanstack/[email protected], npm/@tsconfig/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@vitejs/[email protected], npm/@wagmi/[email protected], npm/@wagmi/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webassemblyjs/[email protected], npm/@webpack-cli/[email protected], npm/@webpack-cli/[email protected], npm/@webpack-cli/[email protected], npm/@xtuc/[email protected], npm/@xtuc/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

Copy link

socket-security bot commented Jun 13, 2024

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

@critesjosh
Copy link
Collaborator

will it be required for people using this to have bun installed?

@signorecello
Copy link
Collaborator Author

No, you can use other package managers :) But bun is pretty powerful

@signorecello
Copy link
Collaborator Author

(I'll add a note in the readme)

@signorecello signorecello requested a review from critesjosh June 14, 2024 08:21
@signorecello signorecello requested review from Savio-Sou and a team June 14, 2024 16:40
Copy link
Collaborator

@critesjosh critesjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! Just a few questions

vite-hardhat/package.json Outdated Show resolved Hide resolved
vite-hardhat/circuit/compile.ts Outdated Show resolved Hide resolved
vite-hardhat/README.md Outdated Show resolved Hide resolved
vite-hardhat/README.md Outdated Show resolved Hide resolved
vite-hardhat/README.md Show resolved Hide resolved
vite-hardhat/hooks/useOnChainVerification.tsx Outdated Show resolved Hide resolved
@signorecello signorecello requested a review from critesjosh June 17, 2024 10:26
@signorecello signorecello merged commit 6ac86ad into main Jul 23, 2024
9 checks passed
@signorecello signorecello deleted the zpedro/holesky branch July 23, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants