Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating to 0.36.0 with oleh's Hardhat Plugin #94

Merged
merged 8 commits into from
Nov 12, 2024

Conversation

signorecello
Copy link
Collaborator

Superseding #93 by integrating Oleh's Hardhat plugin which allows to remove A TON of code.

I'll try to update this example with Honk later on.

@olehmisar
Copy link

also

execSync('npx hardhat compile');

and

should probably be removed. hardhat-plugin-noir hooks into hardhat compile task, so noir is compiled automatically before the tests are run.

@olehmisar
Copy link

and probably remove compile.ts from circuit/ folder

@signorecello
Copy link
Collaborator Author

One thing that will probably give me some white hair is the CI, I can already see it not finding noirup in path... Here we go again...

@olehmisar
Copy link

But the plugin it installs noirup in ~/.nargo folder. Is it not in path or something?

@olehmisar
Copy link

I think it’s possible to use the absolute path for noirup and bbup. I will push a fix today

@olehmisar
Copy link

One thing that will probably give me some white hair is the CI, I can already see it not finding noirup in path... Here we go again...

@signorecello update to [email protected] and ci should pass

@signorecello
Copy link
Collaborator Author

gtg @olehmisar will merge now, thanks!

@signorecello signorecello merged commit d1b9b8d into main Nov 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants