-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Storage to track 2 SDK #413
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even after changing the try catch
I was not able to get this sample to work. The error that I am getting is:
OpenIdConnectProtocolException: Message contains error: 'invalid_client', error_description: 'AADSTS650052: The app needs access to a service (\"https://*.blob.core.windows.net\") that your organization \"da0cc090-dd32-4d9f-984c-130b337f221c\" has not subscribed to or enabled. Contact your IT Admin to review the configuration of your service subscriptions. Trace ID: 3fff6b63-7c9a-4d13-bbdd-bd648e7f0900 Correlation ID: fac325fa-7b75-4ca6-84d6-1e69a8e387ab Timestamp: 2020-09-25 19:47:40Z', error_uri: 'https://login.microsoftonline.com/error?code=650052'.
@jmprieur I dont know if this issue is on M.I.W side, on the AuthorizeForScopes
Steps taken
- Register the app using AppCreation scripts
- Sign-in with a user
- Stop the application and start it again
- Navigate to Blob page
@TiagoBrenck - Can you please try again? |
@jongio even after changing the try catch I was not able to get this sample to work. The
If you follow my steps mentioned here, could you make it to work? |
@TiagoBrenck - Can you please try to run this sample without this PR? We want to make sure it is runable, because the updates we are doing are just to upgrade the libraries, which shouldn't cause the failure you are seeing above. So, basically, try to run from master please and let us know if you can get it to run. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it worked fine.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @FrankieTF and @Shama-K
3-WebApp-multi-APIs/Startup.cs
Outdated
.AddInMemoryTokenCaches(); | ||
services.AddAuthentication(OpenIdConnectDefaults.AuthenticationScheme) | ||
.AddMicrosoftIdentityWebApp(Configuration.GetSection("AzureAd")) | ||
.EnableTokenAcquisitionToCallDownstreamApi(null) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the null should not be necessary. Is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, removed.
@@ -18,9 +18,10 @@ | |||
</ItemGroup> | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Azure.Storage.Blobs" Version="12.6.0" /> | |||
<PackageReference Include="Microsoft.Identity.Client" Version="4.19.0" /> | |||
<PackageReference Include="Microsoft.Identity.Web" Version="0.4.0-preview" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you'll have a merge conflict here. Microsoft.Identity.Web is 1.0.0 now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to latest GA package.
Purpose:
Updated projects (others not related to T1 SDK):
There is a similar repo updated Storage to track 2 SDK