deploy frontend to swa #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IEvangelist
previously approved these changes
Apr 20, 2023
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
Co-authored-by: David Pine <[email protected]>
IEvangelist
reviewed
Apr 20, 2023
Co-authored-by: David Pine <[email protected]>
IEvangelist
approved these changes
Apr 20, 2023
jongio
reviewed
Apr 21, 2023
| @@ -7,6 +7,7 @@ | |||
| <ServiceWorkerAssetsManifest>service-worker-assets.js</ServiceWorkerAssetsManifest> | |||
| <BlazorWebAssemblyLoadAllGlobalizationData>true</BlazorWebAssemblyLoadAllGlobalizationData> | |||
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | |||
| <UserSecretsId>c1ddb026-bba7-49ff-960b-5603e48ee863</UserSecretsId> | |||
There was a problem hiding this comment.
I don't think you want this committed right?
Comment on lines
+12
to
+21
| prepackage: | ||
| shell: pwsh | ||
| run: cd ../;./map-env.ps1 && cd frontend && dotnet publish -p:BACKEND_URI=$env:BACKEND_URI -o build | ||
| continueOnError: false | ||
| interactive: true | ||
| postdeploy: | ||
| shell: pwsh | ||
| run: rm -Force -r ./build | ||
| continueOnError: false | ||
| interactive: true |
| hooks: | ||
| prepackage: | ||
| shell: pwsh | ||
| run: cd ../;./map-env.ps1 && cd frontend && dotnet publish -p:BACKEND_URI=$env:BACKEND_URI -o build |
There was a problem hiding this comment.
You could make this a global hook and not have to do a cd ../
| hooks: | ||
| prepackage: | ||
| shell: pwsh | ||
| run: cd ../;./map-env.ps1 && cd frontend && dotnet publish -p:BACKEND_URI=$env:BACKEND_URI -o build |
There was a problem hiding this comment.
You shouldn't need map-env in a hook. Those values are already available in the hook context.
There was a problem hiding this comment.
Does that mean I don't need to call map-env at all? Can you show me an example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information