Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bicep validation workflow #444

Closed
wants to merge 5 commits into from
Closed

Add Bicep validation workflow #444

wants to merge 5 commits into from

Conversation

pamelafox
Copy link
Collaborator

@pamelafox pamelafox commented Jul 20, 2023

Purpose

This PR adds a GitHub workflow that checks the AZD template for best practices using Defender to DevOps. This change was part of Anthony's #325 PR but he asked me to split that up for easier review.

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Wait for action to complete successfully.

@pamelafox pamelafox changed the title Add workflow Add Bicep validation workflow Jul 20, 2023
@pamelafox
Copy link
Collaborator Author

Unfortunately, the template-analyzer can't handle the unspecified parameter that we added in order to force people to pick a good OpenAI location. I've filed microsoft/security-devops-action#65 and microsoft/security-devops-action#47

I'll close this PR for now and open a PR without the Defender validation.

@pamelafox pamelafox closed this Jul 20, 2023
@pamelafox pamelafox mentioned this pull request Jul 20, 2023
ratkinsoncinz pushed a commit to cinzlab/govgpt-azure-search-openai-demo that referenced this pull request Oct 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant