Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a new helper library Identity Web #88

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Use a new helper library Identity Web #88

merged 2 commits into from
Feb 9, 2023

Conversation

rayluo
Copy link
Contributor

@rayluo rayluo commented Sep 26, 2022

Improvements:

  • The main file app.py shrinks 33% 40% (from 99 lines to 68 60 lines), and becomes much simpler to write.
  • Previously the signed-in session did not expire. Now the new implementation allows declaring session expiration in a one-liner. RBAC could be added in similar fashion, perhaps in next commit. automatically logs user out after their ID token expires. This will resolve Token expiration #46, resolve Somehow invalidate the current session based on the ID token expiration time #47.
  • The improvement above is achieved by moving many helpers into a new standalone helper library identity. After this move, this sample becomes minimalistic, and it is probably unnecessary to unit test this sample. We will close Unit tests for sample code #65.

Identity supports B2C

Pivot to standalone Identity Web
@rayluo rayluo force-pushed the identity-web branch 2 times, most recently from 5cb129e to d13d691 Compare February 9, 2023 18:27
@rayluo rayluo merged commit 9672145 into master Feb 9, 2023
@rayluo rayluo deleted the identity-web branch February 9, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant