Update the mega linter because of GitHub Action deprecations #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkowl
requested review from
jewzaam,
bennerv,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
SudoBrendan
reviewed
May 1, 2023
| EXCLUDED_DIRECTORIES: | ||
| - vendor | ||
| - "vendor" | ||
| - "node_modules" | ||
| YAML_YAMLLINT_CONFIG_FILE: .yaml-lint.yml |
There was a problem hiding this comment.
just noticing that the file edited in this PR and this reference do not align. Am I missing something or is this a typo from a previous commit? The new linter seems to use a different default, one that would work if we actually removed this "custom" one: https://megalinter.io/latest/descriptors/yaml_yamllint/
There was a problem hiding this comment.
the path is still different, dunno why we have that name in particular. I'm not too keen to change it if it works :)
There was a problem hiding this comment.
OH, right. This yaml-lint is for the yaml-lint config in the proj root dir, the one changed in the PR is for the yaml linting GH action.
hawkowl
force-pushed
the
hawkowl/update-megalinter
branch
from
e60b6ff to
2eeccb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Chore from warnings in github
What this PR does / why we need it:
Fixes up deprecation warnings
Test plan for issue:
It is tests :)
Is there any documentation that needs to be updated for this PR?
N/A