Rename TokenCredential variables to indicate credential used #2950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarnes
force-pushed
the
rename-token-credentials
branch
2 times, most recently
from
1d6c17b to
8f5b31e
Compare
|
Please rebase pull request. |
mbarnes
force-pushed
the
rename-token-credentials
branch
from
8f5b31e to
4ec977e
Compare
mbarnes
requested review from
jewzaam,
bennerv,
hawkowl,
rogbas,
petrkotas,
jharrington22,
cblecker,
facchettos,
cadenmarchese,
UlrichSchlueter,
s-amann,
SudoBrendan and
ellis-johnson
as code owners
bennerv
reviewed
Jun 14, 2023
In most cases this will be one of: fpTokenCredential : ARO first-party application spTokenCredential : The cluster's AAD application msiTokenCredential : Managed service identity for the ARO-RP VM
mbarnes
force-pushed
the
rename-token-credentials
branch
from
15d85fb to
743d363
Compare
SudoBrendan
approved these changes
Jun 21, 2023
facchettos
approved these changes
Jun 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
[ARO-1919] AAD: Migrate ARO-RP Azure AD Graph -> Microsoft Graph
What this PR does / why we need it:
Minor follow-up to #1970 where @bennerv requested this in his review.
In most cases the variable rename will be one of:
Test plan for issue:
N/A : Not changing any functionality.
Is there any documentation that needs to be updated for this PR?
No, this is just for code clarity.