Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disable samples manifest to install #4048

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Jan 15, 2025

Which issue this PR addresses:

Fixes ARO-14389

What this PR does / why we need it:

Extends the implementation of #4045 to additionally pass the disabling samples config as an install manifest to Hive/the installer. This ensures that the cluster is born with the Samples operator disabled, rather than waiting until the RP reaches its post-install step to do so.

The post-install step is still retained to absolutely ensure the operator is disabled after install when it needs to be.

Test plan for issue:

  • E2E still passes
  • Manually confirmed on a local installation that the necessary value is added to the manifests secret in the Hive installation cluster:
    $ kubectl get secrets -n ${CLUSTER_NS} cluster-manifests-secret -o jsonpath='{.data.cluster-config-samples\.yaml}' | base64 -d
    apiVersion: samples.operator.openshift.io/v1
    kind: Config
    metadata:
      creationTimestamp: null
      name: cluster
    spec:
      managementState: Removed
    status: {}
    

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

Above testing/validation

@tsatam tsatam changed the title Tsatam/aro 14389 add disablesamples manifest to install Add disable samples manifest to install Jan 15, 2025
@tsatam
Copy link
Collaborator Author

tsatam commented Jan 15, 2025

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant