Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go module deps to fix CVE-2021-4238 #4061

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Update go module deps to fix CVE-2021-4238 #4061

merged 1 commit into from
Jan 28, 2025

Conversation

fahlmant
Copy link
Collaborator

@fahlmant fahlmant commented Jan 27, 2025

Which issue this PR addresses:

https://issues.redhat.com/browse/ARO-14550

What this PR does / why we need it:

github.com/Masterminds/[email protected] is exposed to CVE-2021-4238

On current master:

go mod graph | grep github.com/Masterminds/goutils | while read -r line; do dependency=$(awk '{print $1}' <<<${line}); go mod why -m "${dependency%@*}"; done
# github.com/openshift/machine-config-operator
github.com/Azure/ARO-RP/pkg/monitor/cluster
github.com/openshift/machine-config-operator/pkg/apis/machineconfiguration.openshift.io/v1

After manually updating the dep on machine-config-operator,

go mod graph | grep github.com/Masterminds/goutils | while read -r line; do dependency=$(awk '{print $1}' <<<${line}); go mod why -m "${dependency%@*}"; done
> No Output

Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if checks are green

@fahlmant
Copy link
Collaborator Author

/azp run ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fahlmant fahlmant merged commit 66c8625 into master Jan 28, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants