Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bother bennerv instead of mjudeikis when failing codeql analysis cron #4072

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

bennerv
Copy link
Collaborator

@bennerv bennerv commented Jan 30, 2025

Which issue this PR addresses:

Fixes #4051

What this PR does / why we need it:

Apparently the last person to modify the cron on a scheduled job gets notified about failures. So instead of bothering someone else who no longer is here, we'll bother myself :old-man-yells-at-ben: 🤷

Test plan for issue:

Watch the thing notify me when it fails

Is there any documentation that needs to be updated for this PR?

nope

How do you know this will function as expected in production?

N/a

Copy link
Collaborator

@tsatam tsatam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :old-man-yells-at-ben:

@tsatam tsatam merged commit d4270a7 into master Jan 30, 2025
21 checks passed
@tsatam tsatam deleted the bvesel-modify-cron-for-notification branch January 30, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blast from the past :D
2 participants