Enable $web and disable anonymous blob access on rpversions container #4074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR addresses:
Fixes ARO-14928
What this PR does / why we need it:
Updates our insertion of the deployed RP version into the rpversion storageaccount to use the static website hosting's
$web
container. This will allow us to disable anonymous blob access on the storage account generally, while still allowing access to content within the$web
container.This will require corresponding changes to our consumption of this content, as the URL will change from a
.blob.core.windows.net
URL to.web.core.windows.net
.Test plan for issue:
$web
container$web
container can be accessed anonymously.The entire
saveversion
function could benefit from some dedicated unit tests, I will try to add these in a follow-up effort.Is there any documentation that needs to be updated for this PR?
No
How do you know this will function as expected in production?
Above testing