Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable $web and disable anonymous blob access on rpversions container #4074

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

tsatam
Copy link
Collaborator

@tsatam tsatam commented Jan 31, 2025

Which issue this PR addresses:

Fixes ARO-14928

What this PR does / why we need it:

Updates our insertion of the deployed RP version into the rpversion storageaccount to use the static website hosting's $web container. This will allow us to disable anonymous blob access on the storage account generally, while still allowing access to content within the $web container.

This will require corresponding changes to our consumption of this content, as the URL will change from a .blob.core.windows.net URL to .web.core.windows.net.

Test plan for issue:

  • Deploy this change in a non-production environment and ensure it:
    • Can be deployed over the existing configuration successfully
    • Enables static web hosting on the SA
    • Disables anonymous blob access on the SA
    • Inserts the version information successfully into the $web container
    • The version information within the $web container can be accessed anonymously.

The entire saveversion function could benefit from some dedicated unit tests, I will try to add these in a follow-up effort.

Is there any documentation that needs to be updated for this PR?

No

How do you know this will function as expected in production?

Above testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant