Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue comparing empty lb backend pool list to NIC backend pool list #131

Merged
merged 1 commit into from
Jan 6, 2025
Merged

fix issue comparing empty lb backend pool list to NIC backend pool list #131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...adBalancerUpgrade/module/AzureBasicLoadBalancerUpgrade/AzureBasicLoadBalancerUpgrade.psd1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
RootModule = 'AzureBasicLoadBalancerUpgrade'

# Version number of this module.
ModuleVersion = '2.4.14'
ModuleVersion = '2.4.15'

# Supported PSEditions
# CompatiblePSEditions = @()
Expand Down Expand Up @@ -107,7 +107,7 @@
# IconUri = ''

# ReleaseNotes of this module
ReleaseNotes = 'Added support to retain AutomaticOSUpgrade setting when App Health extension is used instead of health probe.'
ReleaseNotes = 'Fix bug when comparing backend pool membership on empty LBs.'

# Prerelease string of this module
# Prerelease = 'beta'
Expand Down
10 changes: 9 additions & 1 deletion ...grade/module/AzureBasicLoadBalancerUpgrade/modules/ValidateScenario/ValidateScenario.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,8 +407,16 @@ Function Test-SupportedMigrationScenario {
## compare nic backend pool memberships to basicLBBackendIds
try {
$nicBackendPoolMembershipsIds = @()

$nicBackendPoolMembershipsIds += $basicLBVMNics.IpConfigurations.loadBalancerBackendAddressPools.id | Sort-Object | Get-Unique
$differentMembership = Compare-Object $nicBackendPoolMembershipsIds $basicLBBackendIds

If ([string]::IsNullOrEmpty($basicLBBackendIds)) {
# handle LBs with no backend pools
log -Message "[Test-SupportedMigrationScenario] No Basic Load Balancer backend pool IDs provided, so all NIC backend pool IDs must be on another LB (if any)." -Severity Debug
}
Else {
$differentMembership = Compare-Object -ReferenceObject $nicBackendPoolMembershipsIds -DifferenceObject $basicLBBackendIds
}
}
catch {
$message = "[Test-SupportedMigrationScenario] Error comparing NIC backend pool memberships ($($nicBackendPoolMembershipsIds -join ',')) to basicLBBackendIds ($($basicLBBackendIds -join ',')). Error: $($_.Exception.Message)"
Expand Down
Loading