Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding gcp firewall terraform file for quick setup #11223

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

idoshabi07
Copy link
Contributor

@idoshabi07 idoshabi07 commented Oct 6, 2024

Required items, please complete

Change(s):

  • See guidance below

Reason for Change(s):

  • See guidance below

Version Updated:

  • Required only for Detections/Analytic Rule templates
  • See guidance below

Testing Completed:

  • See guidance below

Checked that the validations are passing and have addressed any issues that are present:

  • See guidance below

Guidance <- remove section before submitting


Before submitting this PR please ensure that you have read the following sections and filled out the changes, reason for change and testing complete sections:

Thank you for your contribution to the Microsoft Sentinel Github repo.

Details of the code changes in your submitted PR. Providing descriptions for pull requests ensures there is context to changes being made and greatly enhances the code review process. Providing associated Issues that this resolves also easily connects the reason.

Change(s):

  • Updated syntax for XYZ.yaml

Reason for Change(s):

Version updated:

  • Yes
  • Detections/Analytic Rule templates are required to have the version updated

The code should have been tested in a Microsoft Sentinel environment that does not have any custom parsers, functions or tables, so that you validate no incorrect syntax and execution functions properly. If your submission requires a custom parser or function, it must be submitted with the PR.

Testing Completed:

  • Yes/No/Need Help

Note: If updating a detection, you must update the version field.

Before the submission has been made, please look at running the KQL and Yaml Validation Checks locally.
https://github.com/Azure/Azure-Sentinel#run-kql-validation-locally

Checked that the validations are passing and have addressed any issues that are present:

  • Yes/No/Need Help

Note: Let us know if you have tried fixing the validation error and need help.

References:


@idoshabi07 idoshabi07 requested review from a team as code owners October 6, 2024 08:16
@v-prasadboke
Copy link
Contributor

Hello @idoshabi07, Please fill out the PR template.
Also accept license agreement

@v-prasadboke v-prasadboke self-assigned this Oct 7, 2024
@v-prasadboke v-prasadboke added the Solution Solution specialty review needed label Oct 7, 2024
@idoshabi07
Copy link
Contributor Author

idoshabi07 commented Oct 8, 2024

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree company="Microsoft"

@idoshabi07
Copy link
Contributor Author

@idoshabi07 the command you issued was incorrect. Please try again.

Examples are:

@microsoft-github-policy-service agree

and

@microsoft-github-policy-service agree company="your company"

@microsoft-github-policy-service agree company="Microsoft"

@idoshabi07
Copy link
Contributor Author

Hello @idoshabi07, Please fill out the PR template. Also accept license agreement

done

@v-atulyadav v-atulyadav merged commit da1102f into Azure:master Oct 8, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Solution Solution specialty review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants