Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimal refactor for dfs sake + full support for sql #1933

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mahmoudbahaa
Copy link

@mahmoudbahaa mahmoudbahaa commented Apr 22, 2023

To allow dfs changes in incremental approach i created this PR as a 1st step in implementing dfs endpoint.it has the following:

  • Minimal changes for blob end point to allow for extension in dfs endpoint
  • Full support for sql for the same features supported by Loki
  • Added clearDb option to configurations in and set it to true in the test cases
  • Added better support for using postgreSQL without breaking mysql
  • Added "@loki @SQL" to all test cases except 2

@mahmoudbahaa mahmoudbahaa force-pushed the dataLakeStorage-support-2-phase1 branch 3 times, most recently from ff40a11 to 4e363b2 Compare April 22, 2023 02:11
@blueww
Copy link
Member

blueww commented Apr 27, 2023

@mahmoudbahaa

Thanks so much for raising the 2 PRs for datalakeGen2 support!
Consider the effort to review/refine the PRs should be big, could we have a meeting to discuss this in detail?

I will be on public holiday from 4/29-5/3. Could we have the meeting on 5/5 or 5/6?
My working hour is 1:00-10:00 UTC. Would you please help to share your available time, and I will setup the meeting.

@mahmoudbahaa
Copy link
Author

@blueww I should be avalaible 5/5 1:00 to 4:00 UTC or 5/6 7:00UTC to 10:00 UTC

@mahmoudbahaa mahmoudbahaa force-pushed the dataLakeStorage-support-2-phase1 branch 6 times, most recently from 316cfe1 to e9e705a Compare April 28, 2023 02:21
…dpoint

* Added clearDb option to configurations in and set it to true in the test cases
@mahmoudbahaa mahmoudbahaa force-pushed the dataLakeStorage-support-2-phase1 branch from e9e705a to 12269ca Compare April 28, 2023 02:46
@blueww
Copy link
Member

blueww commented Apr 28, 2023

@mahmoudbahaa

Thanks for the reply!

I just get more persons need be included in the meeting.
I will confirm the schedule internally and setup the meeting.

@blueww
Copy link
Member

blueww commented May 2, 2023

@mahmoudbahaa
I have setup a meeting at 5/5 1:00-1:30 UTC, to the email of your github account.
Feel free to let me know if you have any issue to join the meeting.

@blueww
Copy link
Member

blueww commented May 25, 2023

@mahmoudbahaa

Greetings.
We had some internal discussion and get some idea.
Would you like to have a meeting with us this or next week to discuss the plan to implement ADLSgen2 in Azurite?

I have sent a mail to you last week but seems not get your responds.
Would you please help to reply the mail, and confirm the available time for you?

@Sazeidya
Copy link

Sazeidya commented Jul 9, 2023

Hello together,

thank you very much @mahmoudbahaa for the hard work put into this to provide DataLake2 emulation support. As this looks really promising, I wanted to ask about the current status of this? It would be a shame if all the hard work would not make it to the final product.

Also maybe there is something that other people (like me) could help with?

Thanks a lot and have a nice week!

@blueww
Copy link
Member

blueww commented Jul 10, 2023

@Sazeidya

Thanks for ping this!

Thanks for @mahmoudbahaa raising this PR!
We tried to contact him to share our comments for this PR in multiple ways (after having meeting with him once), but not hear from him for a long time.

For this PR, I am afraid this still not meet our expectation and merge bar, and might has limitations to fully implementation ADLSgen2 functions in the future.

We are working on a public guidance for our requirements and general expectations for PRs that add new functionality to Azurite on the scale of a new endpoint implementation such as ADLSGen2. It's still in review before being public.

Azurite welcome contribution!
We really hope working together with community to have ADLSGen2 implemented in Azurite!

@blueww
Copy link
Member

blueww commented Jul 20, 2023

We have added a wiki for our requirements and general expectations of PRs that add new ADLS Gen2 to Azurite.
https://github.com/Azure/Azurite/wiki/ADLS-Gen2-Implementation-Guidance

Azurite welcome contribution!
If you would like help to implement ADLS Gen2 in Azurite, please read the wiki and follow it to design/implement ADLS Gen2 in Azurite (better review the detail design with us first), to get a smooth PR review / merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants