[Modules] Configure privateDnsZoneGroups on redisCache (#1927)

* privateDNSResourceIds * readme
Azure · Sep 6, 2022 · a203401 · a203401
1 parent 7830317
commit a203401
Show file tree

Hide file tree

Showing 3 changed files with 80 additions and 65 deletions.
diff --git a/modules/Microsoft.Cache/redis/.test/min.parameters.json b/modules/Microsoft.Cache/redis/.test/min.parameters.json
@@ -1,9 +1,9 @@
 {
-  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
-  "contentVersion": "1.0.0.0",
-  "parameters": {
-    "name": {
-      "value": "<<namePrefix>>-az-redis-min-001"
+    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
+    "contentVersion": "1.0.0.0",
+    "parameters": {
+        "name": {
+            "value": "<<namePrefix>>-az-redis-min-001"
+        }
     }
-  }
 }
diff --git a/modules/Microsoft.Cache/redis/.test/parameters.json b/modules/Microsoft.Cache/redis/.test/parameters.json
@@ -1,63 +1,68 @@
 {
-  "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
-  "contentVersion": "1.0.0.0",
-  "parameters": {
-    "name": {
-      "value": "<<namePrefix>>-az-redis-full-001"
-    },
-    "capacity": {
-      "value": 2
-    },
-    "diagnosticLogCategoriesToEnable": {
-      "value": [
-        "ApplicationGatewayAccessLog",
-        "ApplicationGatewayFirewallLog"
-      ]
-    },
-    "diagnosticMetricsToEnable": {
-      "value": [
-        "AllMetrics"
-      ]
-    },
-    "enableNonSslPort": {
-      "value": true
-    },
-    "lock": {
-      "value": "CanNotDelete"
-    },
-    "minimumTlsVersion": {
-      "value": "1.2"
-    },
-    "diagnosticSettingsName": {
-      "value": "redisdiagnostics"
-    },
-    "publicNetworkAccess": {
-      "value": "Enabled"
-    },
-    "redisVersion": {
-      "value": "6"
-    },
-    "skuName": {
-      "value": "Premium"
-    },
-    "systemAssignedIdentity": {
-      "value": true
-    },
-    "shardCount": {
-      "value": 1
-    },
-    "tags": {
-      "value": {
-        "resourceType": "Redis Cache"
-      }
-    },
-    "privateEndpoints": {
-      "value": [
-        {
-          "subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints",
-          "service": "redisCache"
+    "$schema": "https://schema.management.azure.com/schemas/2019-04-01/deploymentParameters.json#",
+    "contentVersion": "1.0.0.0",
+    "parameters": {
+        "name": {
+            "value": "<<namePrefix>>-az-redis-full-001"
+        },
+        "capacity": {
+            "value": 2
+        },
+        "diagnosticLogCategoriesToEnable": {
+            "value": [
+                "ApplicationGatewayAccessLog",
+                "ApplicationGatewayFirewallLog"
+            ]
+        },
+        "diagnosticMetricsToEnable": {
+            "value": [
+                "AllMetrics"
+            ]
+        },
+        "enableNonSslPort": {
+            "value": true
+        },
+        "lock": {
+            "value": "CanNotDelete"
+        },
+        "minimumTlsVersion": {
+            "value": "1.2"
+        },
+        "diagnosticSettingsName": {
+            "value": "redisdiagnostics"
+        },
+        "publicNetworkAccess": {
+            "value": "Enabled"
+        },
+        "redisVersion": {
+            "value": "6"
+        },
+        "skuName": {
+            "value": "Premium"
+        },
+        "systemAssignedIdentity": {
+            "value": true
+        },
+        "shardCount": {
+            "value": 1
+        },
+        "tags": {
+            "value": {
+                "resourceType": "Redis Cache"
+            }
+        },
+        "privateEndpoints": {
+            "value": [
+                {
+                    "subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints",
+                    "service": "redisCache",
+                    "privateDnsZoneGroup": {
+                        "privateDNSResourceIds": [
+                            "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.redis.cache.windows.net"
+                        ]
+                    }
+                }
+            ]
         }
-      ]
     }
-  }
 }
diff --git a/modules/Microsoft.Cache/redis/readme.md b/modules/Microsoft.Cache/redis/readme.md
@@ -399,6 +399,11 @@ module redis './Microsoft.Cache/redis/deploy.bicep' = {
     minimumTlsVersion: '1.2'
     privateEndpoints: [
       {
+        privateDnsZoneGroup: {
+          privateDNSResourceIds: [
+            '/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.redis.cache.windows.net'
+          ]
+        }
         service: 'redisCache'
         subnetResourceId: '/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints'
       }
@@ -461,6 +466,11 @@ module redis './Microsoft.Cache/redis/deploy.bicep' = {
     "privateEndpoints": {
       "value": [
         {
+          "privateDnsZoneGroup": {
+            "privateDNSResourceIds": [
+              "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/privateDnsZones/privatelink.redis.cache.windows.net"
+            ]
+          },
           "service": "redisCache",
           "subnetResourceId": "/subscriptions/<<subscriptionId>>/resourceGroups/validation-rg/providers/Microsoft.Network/virtualNetworks/adp-<<namePrefix>>-az-vnet-x-001/subnets/<<namePrefix>>-az-subnet-x-005-privateEndpoints"
         }