Skip to content

Commit

Permalink
Changed login away from secret as user name is not defined as secure()
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexanderSehr committed Jul 14, 2022
1 parent 25c7662 commit dd6d95a
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 13 deletions.
7 changes: 1 addition & 6 deletions modules/Microsoft.Sql/servers/.test/parameters.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,7 @@
"value": "CanNotDelete"
},
"administratorLogin": {
"reference": {
"keyVault": {
"id": "/subscriptions/<<subscriptionId>>/resourceGroups/<<resourceGroupName>>/providers/Microsoft.KeyVault/vaults/adp-<<namePrefix>>-az-kv-x-001"
},
"secretName": "administratorLogin"
}
"value": "adminUserName"
},
"administratorLoginPassword": {
"reference": {
Expand Down
9 changes: 2 additions & 7 deletions modules/Microsoft.Sql/servers/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -388,12 +388,7 @@ module servers './Microsoft.Sql/servers/deploy.bicep' = {
"value": "CanNotDelete"
},
"administratorLogin": {
"reference": {
"keyVault": {
"id": "/subscriptions/<<subscriptionId>>/resourceGroups/<<resourceGroupName>>/providers/Microsoft.KeyVault/vaults/adp-<<namePrefix>>-az-kv-x-001"
},
"secretName": "administratorLogin"
}
"value": "adminUserName"
},
"administratorLoginPassword": {
"reference": {
Expand Down Expand Up @@ -505,7 +500,7 @@ module servers './Microsoft.Sql/servers/deploy.bicep' = {
params: {
name: '<<namePrefix>>-az-sqlsrv-x-001'
lock: 'CanNotDelete'
administratorLogin: kv1.getSecret('administratorLogin')
administratorLogin: 'adminUserName'
administratorLoginPassword: kv1.getSecret('administratorLoginPassword')
location: 'westeurope'
minimalTlsVersion: '1.2'
Expand Down

0 comments on commit dd6d95a

Please sign in to comment.