Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] VM: Added proximityPlacementGroup test + changed param format #1760

Merged
merged 13 commits into from
Aug 8, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Aug 7, 2022

Description

  • Added reference to proximityPlacementGroup to test files in VM & VMSS
  • Changed format of diverse parameters to request resourceID instead of just name as e.g. the proximityPlacementGroup may be in a different RG or subsciption
  • Replaced ProximityGroupDeployment in VMSS deployment with ProximityGroupResourceID reference to align with VM module

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Compute: VirtualMachines
Compute: VirtualMachineScaleSets

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@AlexanderSehr AlexanderSehr requested a review from a team as a code owner August 7, 2022 13:05
@AlexanderSehr AlexanderSehr added enhancement New feature or request [cat] modules category: modules labels Aug 7, 2022
@AlexanderSehr AlexanderSehr linked an issue Aug 7, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) August 7, 2022 13:06
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

Unit Test Results

  1 files    1 suites   23s ⏱️
79 tests 78 ✔️ 1 💤 0
82 runs  81 ✔️ 1 💤 0

Results for commit 1f6b705.

♻️ This comment has been updated with latest results.

@AlexanderSehr AlexanderSehr requested a review from eriqua August 7, 2022 18:35
@AlexanderSehr AlexanderSehr requested a review from eriqua August 8, 2022 06:43
@AlexanderSehr AlexanderSehr merged commit 5042c3d into main Aug 8, 2022
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr deleted the users/alsehr/1173_vmprox branch August 8, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add testing for VM for proximityPlacementGroups
2 participants