Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modules] Adding Standard SKU Options to bastionHosts #1801

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

ChrisSidebotham
Copy link
Contributor

Description

Addition of standard SKU options to support tunnelling, native client and enable/disable features.

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
Network: BastionHosts

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

@ChrisSidebotham ChrisSidebotham requested a review from a team as a code owner August 25, 2022 13:13
@ChrisSidebotham ChrisSidebotham added the [cat] modules category: modules label Aug 25, 2022
@ChrisSidebotham ChrisSidebotham linked an issue Aug 25, 2022 that may be closed by this pull request
Copy link
Contributor

@ahmadabdalla ahmadabdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment regarding test coverage for the minimum set of parameters

@ahmadabdalla ahmadabdalla merged commit 0d8a80e into main Aug 26, 2022
@ahmadabdalla ahmadabdalla deleted the users/csidebotham/bastion-standard-sku-options branch August 26, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Add Azure Bastion options for tunnelling
2 participants