Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Utilities] Reduced the Set-ModuleReadMe script's dependency on the CARML folder structure + smaller logical improvments #1989

Merged
merged 2 commits into from
Sep 9, 2022
Merged

[Utilities] Reduced the Set-ModuleReadMe script's dependency on the CARML folder structure + smaller logical improvments #1989

merged 2 commits into from
Sep 9, 2022

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Sep 9, 2022 •
edited
Loading

Description

  • Reduced the Set-ModuleReadMe script's dependency on the CARML folder structure (splitting at Microsoft. instead of /modules/) to allow usage of script also outside the CARML 'module' folder
  • Smaller logical improvments (e.g. less places with splits)
  • Refreshed ReadMe's to apply a small visual update to deployment examples

Pipeline references

For module/pipeline changes, please create and attach the status badge of your successful run.

Pipeline
AnalysisServices: Servers

Type of Change

Please delete options that are not relevant.

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Update to documentation

@AlexanderSehr AlexanderSehr added documentation Improvements or additions to documentation [cat] modules category: modules [cat] utilities category: utilities labels Sep 9, 2022
@AlexanderSehr AlexanderSehr added this to the Release 0.7 milestone Sep 9, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

Unit Test Results

  1 files    1 suites   26s ⏱️
53 tests 53 ✔️ 0 💤 0 ❌
55 runs  55 ✔️ 0 💤 0 ❌

Results for commit f1b2298.

@AlexanderSehr AlexanderSehr marked this pull request as ready for review September 9, 2022 08:55
@AlexanderSehr AlexanderSehr requested a review from a team as a code owner September 9, 2022 08:55
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) September 9, 2022 09:02
@AlexanderSehr AlexanderSehr merged commit 14496a5 into main Sep 9, 2022
@AlexanderSehr AlexanderSehr deleted the users/alsehr/readmeSplit branch September 9, 2022 09:08
@eriqua eriqua changed the title [Documentation] Reduced the Set-ModuleReadMe script's dependency on the CARML folder structure + smaller logical improvments [Utilities] Reduced the Set-ModuleReadMe script's dependency on the CARML folder structure + smaller logical improvments Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahalan rahalan rahalan approved these changes

Assignees

@AlexanderSehr AlexanderSehr

Labels
[cat] modules category: modules [cat] utilities category: utilities documentation Improvements or additions to documentation
Projects
None yet
Milestone
Release 0.7
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexanderSehr @rahalan