Enable git hooks #679
Open
Enable git hooks #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kairu-ms
reviewed
Feb 6, 2025
| Write-Host "Running: aaz-dev command-model verify -a $GitRoot -t $_" -ForegroundColor Yellow # For logging | ||
| aaz-dev command-model verify -a $GitRoot -t $_ | ||
| if ($LASTEXITCODE -ne 0) { | ||
| exit 1 |
There was a problem hiding this comment.
Please provide feature instructions if it failed in verification
There was a problem hiding this comment.
aaz-dev command-model verify itself contains information about why the verification failed.
kairu-ms
reviewed
Feb 6, 2025
Comment on lines
+7
to
+11
| $Modules = $ChangedFiles | | ||
| Where-Object { $_ -like "Commands/*" } | # Filter files under commands folder | ||
| ForEach-Object { ($_ -replace "^Commands/", "") } | # Remove the prefix | ||
| ForEach-Object { ($_ -split "/")[0] } | # Extract the moudule | ||
| Sort-Object -Unique # Ensure uniqueness |
There was a problem hiding this comment.
actually I think we can verify the whole aaz repo if it doesn't take long time. BTW, please add git rebase operation to sync with the upstream repo
There was a problem hiding this comment.
it will take over 5 minutes, affect the user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.