-
Notifications
You must be signed in to change notification settings - Fork 521
chore: rev default etcd version to 3.4.13 #3748
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3748 +/- ##
=======================================
Coverage 73.19% 73.19%
=======================================
Files 148 148
Lines 25394 25394
=======================================
Hits 18587 18587
Misses 5671 5671
Partials 1136 1136
Continue to review full report at Codecov.
|
So, after going through this prototype exercise to make etcd 3.4 work, I strongly suspect that maintaining a common configuration surface area that will work across all the currently supported etcd versions is not tenable. We should strongly consider introducing 3.4 as a "you can't go back to 3.3 or prior" change. |
Interesting - we should look at a what this buys us. We have a lot of miles on 3.3.x but we know that there are demons in there. We should ask the aks team what they saw with 3.4 vs 3.3 in their setup. However, there have been critical fixes that went into 3.4 first and then backported to 3.3. For example, you really don't want to be at or before 3.3.13 due to at least one critical issue that was first fixed in 3.4 and then finally backported to 3.3.14 |
c3f8462
to
18569c7
Compare
Just fyi, as of Kubernetes 1.19.1, etcd server 3.4.13 is the default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis, mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR is not compatible w/ etcd 3.3 and below |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closing per @jackfrancis, given AKS Engine deprecation. |
Reason for Change:
This PR updates the default etcd version to v3.4.25 or control plane nodes.
Ref:
https://github.com/etcd-io/etcd/releases/tag/v3.4.13
Issue Fixed:
Fixes #3663
Requirements:
Notes: