Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

chore: rev default etcd version to 3.4.13 #3748

Closed
wants to merge 5 commits into from

Conversation

jackfrancis
Copy link
Member

Reason for Change:

This PR updates the default etcd version to v3.4.25 or control plane nodes.

Ref:

https://github.com/etcd-io/etcd/releases/tag/v3.4.13

Issue Fixed:

Fixes #3663

Requirements:

Notes:

@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #3748 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3748   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files         148      148           
  Lines       25394    25394           
=======================================
  Hits        18587    18587           
  Misses       5671     5671           
  Partials     1136     1136           
Impacted Files Coverage Δ
pkg/api/vlabs/validate.go 80.15% <ø> (ø)
pkg/engine/templates_generated.go 53.42% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bad19f...18569c7. Read the comment docs.

@acs-bot acs-bot added size/M and removed size/S labels Aug 25, 2020
@jackfrancis
Copy link
Member Author

So, after going through this prototype exercise to make etcd 3.4 work, I strongly suspect that maintaining a common configuration surface area that will work across all the currently supported etcd versions is not tenable. We should strongly consider introducing 3.4 as a "you can't go back to 3.3 or prior" change.

cc @Michael-Sinz @devigned

@Michael-Sinz
Copy link
Collaborator

Interesting - we should look at a what this buys us. We have a lot of miles on 3.3.x but we know that there are demons in there.

We should ask the aks team what they saw with 3.4 vs 3.3 in their setup. However, there have been critical fixes that went into 3.4 first and then backported to 3.3. For example, you really don't want to be at or before 3.3.13 due to at least one critical issue that was first fixed in 3.4 and then finally backported to 3.3.14

@mboersma mboersma added the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Aug 31, 2020
@mboersma mboersma removed the needs-rebase Changes in the target branch require a `git rebase` and `git push -f` label Sep 11, 2020
@mboersma
Copy link
Member

Just fyi, as of Kubernetes 1.19.1, etcd server 3.4.13 is the default.

Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@acs-bot
Copy link

acs-bot commented Sep 14, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jackfrancis
Copy link
Member Author

This PR is not compatible w/ etcd 3.3 and below

@mboersma mboersma added needs-rebase Changes in the target branch require a `git rebase` and `git push -f` and removed lgtm labels Sep 15, 2020
@stale
Copy link

stale bot commented Oct 17, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 17, 2020
@stale stale bot removed the stale label Oct 19, 2020
@bridgetkromhout
Copy link
Contributor

Closing per @jackfrancis, given AKS Engine deprecation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved backlog do-not-merge/hold needs-rebase Changes in the target branch require a `git rebase` and `git push -f` size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add etcd 3.4 support
5 participants