Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate whether GetRawText should be used instead of ToString for generated deserialization code #2886

Open
JoshLove-msft opened this issue Nov 29, 2022 · 0 comments

Comments

@JoshLove-msft
Copy link
Member

JoshLove-msft commented Nov 29, 2022

For code paths where we are calling into JsonSerializer.Deserialize, we would need to use GetRawText if the underlying JSON type can be something other than object. This has come up in #2852.

In that PR, I've updated the specific case that DFE and SystemData falls under, but there are several other places in JsonCodeWriterExtensions where we pass ToString to JsonSerializer.Deserialize that should be evaluated for the same change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant