Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x-ms-format mappings for DataFactoryExpression<T> #2852

Merged
merged 44 commits into from
Dec 6, 2022
Merged

Add x-ms-format mappings for DataFactoryExpression<T> #2852

merged 44 commits into from
Dec 6, 2022

Conversation

JoshLove-msft
Copy link
Member

Description

Add your description here!

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@JoshLove-msft
Copy link
Member Author

Created #2871 and #2870 as follow ups.

@JoshLove-msft
Copy link
Member Author

I've generated against azure-sdk-for-net with these changes and confirmed there is no diff.

@JoshLove-msft JoshLove-msft mentioned this pull request Nov 29, 2022
Open
@JoshLove-msft
Copy link
Member Author

I've generated against azure-sdk-for-net with these changes and confirmed there is no diff.

This is no longer the case with the GetRawText change.

@ArthurMa1978 ArthurMa1978 linked an issue Nov 30, 2022 that may be closed by this pull request
[FEATURE REQ] Add sdk support for DataFactoryExpression Azure/azure-sdk-for-net#31507
Closed
@JoshLove-msft
Copy link
Member Author

Diff - Azure/azure-sdk-for-net#32822

@JoshLove-msft JoshLove-msft merged commit 319a69f into Azure:feature/v3 Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-nash m-nash m-nash approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@AlexanderSher AlexanderSher Awaiting requested review from AlexanderSher

@lirenhe lirenhe Awaiting requested review from lirenhe

@chunyu3 chunyu3 Awaiting requested review from chunyu3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE REQ] Add sdk support for DataFactoryExpression
2 participants
@JoshLove-msft @m-nash