Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update conftest for spector #2985

Merged
merged 7 commits into from
Jan 3, 2025
Merged

update conftest for spector #2985

merged 7 commits into from
Jan 3, 2025

Conversation

msyyc
Copy link
Member

@msyyc msyyc commented Jan 3, 2025 •
edited
Loading

  • For unbranded, spector asks there is only report related with http-specs, so we can't run same command for unbranded and azure. For azure, we shall include specs of both azure-http-specs and http-specs; for unbranded, we shall only include http-specs.
  • some cases are only for azure so we need to move the test case into azure folder

effect:
image

image

@msyyc msyyc marked this pull request as ready for review January 3, 2025 04:58
@msyyc msyyc mentioned this pull request Jan 3, 2025
Merged
@tadelesh tadelesh merged commit 4387a34 into main Jan 3, 2025
16 checks passed
@tadelesh tadelesh deleted the spector-migration-dashboard-fix branch January 3, 2025 05:37
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jan 3, 2025
@msyyc
[python] update test for spector (#5478)
d078676 
Sync with Azure/autorest.python#2985
- For unbranded, spector asks there is only report related with
http-specs, so we can't run same command for unbranded and azure. For
azure, we shall include specs of both azure-http-specs and http-specs;
for unbranded, we shall only include http-specs.
- some cases are only for azure so we need to move the test case into
azure folder
github-merge-queue bot pushed a commit to microsoft/typespec that referenced this pull request Jan 3, 2025
@msyyc
[python] update test for spector (#5478)
4fd8d1f 
Sync with Azure/autorest.python#2985
- For unbranded, spector asks there is only report related with
http-specs, so we can't run same command for unbranded and azure. For
azure, we shall include specs of both azure-http-specs and http-specs;
for unbranded, we shall only include http-specs.
- some cases are only for azure so we need to move the test case into
azure folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@iscai-msft iscai-msft Awaiting requested review from iscai-msft iscai-msft is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msyyc @tadelesh