This repository has been archived by the owner on Feb 3, 2021. It is now read-only.
Feature: Add ability to specify docker run options in toolkit config #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature gives aztk users the ability to customize Docker configuration by specifying command line options for
docker run. These are specified as a single string, either in the toolkit section of cluster.yaml/job.yaml or on the command line of thecluster createcommand, and injected into thedocker runcommand just before the image name.To prevent arbitrary commands from being executed through abuse of this parameter, I have restricted the set of permitted characters to something that I think will be safe, but still sufficiently expressive.
It will still be possible for the user to pass command line arguments that are malformed (e.g. --prvilged), that don't make sense in an aztk context (e.g. --help), or that duplicate or conflict with the
docker runarguments already set by aztk (--net; --name; -d; several instances of -v, -p, and -e). If this happens, the user will have to look at the start task logs to debug.