Bugfix: Message disposition hangs infinitely when the operation times out #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting latest develop from base fork
Update Develop branch from base fork
…ched. When timer callback is called, the disposition-work was being completed as 'syncCompleted=true'. This isn't true and should have been false. Because of this, the EndDispose didn't end up being called and hence this would lead to an infinite block.
|
@varunpuranik @abhipsaMisra @prmathur-microsoft @alextolp @rajeevmv FYI - this could be the cause of some of the AMQP deadlocks we're seeing during IoT SDK testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing a bug in disposeAsyncResult when operationTimeout limit is reached.
When timer callback is called, the disposition-work was being completed as 'syncCompleted=true'. This isn't true and should have been false. Because of this, the EndDispose didn't end up being called and hence this would lead to an infinite block.