[hotfix] Temporary increase performance threshold to 400 for CDN #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haroldrandom
changed the title
jiasli
reviewed
Mar 11, 2020
| @@ -15,7 +15,7 @@ | |||
| logger = get_logger(__name__) | |||
|
|
|||
| TOTAL = 'ALL' | |||
| TOTAL_THRESHOLD = 300 | |||
| TOTAL_THRESHOLD = 400 # temporary increase to 400 for CDN | |||
There was a problem hiding this comment.
I don't think changing this value is enough. We also need to tweak THRESHOLDS.
But let me investigate why CDN is slow first.
|
Fixed the CDN module's high loading time issue with Azure/azure-cli#12535 This PR can still be useful if we see similar issues again but can't fix it quickly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Azure/azure-cli#12534