Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom headers #1104

Merged
merged 3 commits into from
Dec 10, 2019
Merged

Custom headers #1104

merged 3 commits into from
Dec 10, 2019

Conversation

weinong
Copy link
Contributor

@weinong weinong commented Nov 21, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/weinong/azure-cli-extensions.git@custom-headers#subdirectory=src/$EXT&egg=$EXT"

Copy link

@yangl900 yangl900 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be super useful. thanks!

@fengzhou-msft
Copy link
Member

please take a look at the travis log and fix the issue.

@weinong
Copy link
Contributor Author

weinong commented Nov 21, 2019

@fengzhou-msft fixed. thanks!

@weinong
Copy link
Contributor Author

weinong commented Dec 10, 2019

@haroldrandom @fengzhou-msft can we merge this soon?

@fengzhou-msft fengzhou-msft merged commit c9b33f4 into Azure:master Dec 10, 2019
ManuInNZ pushed a commit to ManuInNZ/azure-cli-extensions that referenced this pull request Apr 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants