Unable to copy image to another resource group

[imabedalghafer]

Command Name
az image copy Extension Name: image-copy-extension. Version: 0.2.2.

Errors:

Command '['/usr/bin/python', '-m', 'azure.cli', 'snapshot', 'create', '--name', 'optimizerredis-0.1.3_os_disk_snapshot', '--resource-group', 'sa-beta', '--source', u'https://factoryoptimizerred2235.blob.core.windows.net/vhds/optimizerredis-0.1.3.vhd', '--output', 'json', '--tags', 'created_by=image-copy-extension']' returned non-zero exit status 1 Traceback (most recent call last): python2.7/site-packages/knack/cli.py, ln 206, in invoke cmd_result = self.invocation.execute(args)

Suggested Solution:
Add a new variable to get the storage account id that is created and then pass it to create the snapshot. as in below example :

json_output = run_cli_command(cli_cmd, return_as_json=True)
target_blob_endpoint = json_output['primaryEndpoints']['blob']
target_sa_id = json_output['id']

and on the command to create the new snapshot:
cli_cmd = prepare_cli_command(['snapshot', 'create',
'--resource-group', snapshot_resource_group_name,
'--name', target_snapshot_name,
'--location', location,
'--source', target_blob_path,
'--source-storage-account-id', target_sa_id ],
subscription=target_subscription)

Tested locally and it is working as expected.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

[azuresdkci]

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/imabedalghafer/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

[tamirkamara]

@imabedalghafer, thank you for this contribution.
Can you please edit the title and description of this issue to explain?

I think we should wait for a proper response on the root issue before going to fix something that might result in other issues down the line.
Original issue on the extension is here: #1097

[jsntcy]

@qwordy, please help review it, thanks.

[jsntcy]

@qwordy, please help review it, thanks.

[qwordy]

I check the code. There is already a fix in the code. You need to git fetch/pull the latest version

[qwordy]

We are very sorry that this PR will not be merged. This bug has been fixed by another PR before this PR. Thanks for your contribution. You can install latest version of image copy and try it.