Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fix for Approuting CLI - added operation_group for key vault #7037

Closed
wants to merge 20 commits into from

Conversation

bosesuneha
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks approuting update -g 'resource_group' -n 'cluster_name' --enable-kv --attach-kv 'keyvault_id'

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 28, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @bosesuneha,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 28, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@bosesuneha bosesuneha changed the title Fix for Approuting CLI - added operation_group for key vault [AKS] Fix for Approuting CLI - added operation_group for key vault Nov 28, 2023
@bosesuneha bosesuneha closed this Nov 28, 2023
@bosesuneha bosesuneha deleted the fix-for-approuting-cli branch November 28, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants