Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} az aks update: Add --ip-families to support updating cluster networking settings #7040

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

tyler-lloyd
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks update --ip-families ipv4,ipv6

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 28, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter ip_families

Copy link

Hi @tyler-lloyd,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @tyler-lloyd,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 28, 2023

AKS

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change generally looks good to me.

Could you please help add a scenario test (examples in file test_aks_commands.py), or update some of the existing ones to test the new option in az aks update?

  • test_aks_create_dualstack_with_default_network
  • test_aks_create_with_default_network
  • test_aks_create_and_update_ipv6_count

@tyler-lloyd
Copy link
Contributor Author

The change generally looks good to me.

Could you please help add a scenario test (examples in file test_aks_commands.py), or update some of the existing ones to test the new option in az aks update?

  • test_aks_create_dualstack_with_default_network
  • test_aks_create_with_default_network
  • test_aks_create_and_update_ipv6_count

@FumingZhang - the feature is not enabled yet and is only going to be tested by internal partners until we are ready for public preview. Can we agree to add a live test before we open to public preview?

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyler-lloyd
Copy link
Contributor Author

@zhoxing-ms PTAL

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 16, 2023

Please fix CI issues.

@tyler-lloyd tyler-lloyd force-pushed the update-ipfamilies branch 2 times, most recently from aefe21b to 729ddcf Compare December 19, 2023 20:43
@tyler-lloyd
Copy link
Contributor Author

@FumingZhang could you help take a look at the failing azdev style CI pipeline? None of the errors appear related to changes that I've made in this PR.

@FumingZhang
Copy link
Member

image
Yep, I'll fix the lint issues in a separate PR later.

@tyler-lloyd
Copy link
Contributor Author

Please fix CI issues.

@yonzhan - CI issues are fixed now.

@tyler-lloyd tyler-lloyd force-pushed the update-ipfamilies branch 2 times, most recently from c3d9b43 to 8902fa6 Compare January 2, 2024 13:06
@FumingZhang
Copy link
Member

image Yep, I'll fix the lint issues in a separate PR later.

I've fixed the style issues, please rebase from main to pull the fixes. And fix any error in the failed CI check Azure.azure-cli-extensions (azdev style on Modified Extensions).

@yanzhudd yanzhudd merged commit 935fb46 into Azure:main Jan 12, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants