-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{AKS} az aks update
: Add --ip-families
to support updating cluster networking settings
#7040
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks update | cmd aks update added parameter ip_families |
Hi @tyler-lloyd, |
Hi @tyler-lloyd, |
AKS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change generally looks good to me.
Could you please help add a scenario test (examples in file test_aks_commands.py
), or update some of the existing ones to test the new option in az aks update
?
- test_aks_create_dualstack_with_default_network
- test_aks_create_with_default_network
- test_aks_create_and_update_ipv6_count
5ace7dd
to
850c41e
Compare
@FumingZhang - the feature is not enabled yet and is only going to be tested by internal partners until we are ready for public preview. Can we agree to add a live test before we open to public preview? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@zhoxing-ms PTAL |
850c41e
to
d2d0bae
Compare
Please fix CI issues. |
aefe21b
to
729ddcf
Compare
@FumingZhang could you help take a look at the failing azdev style CI pipeline? None of the errors appear related to changes that I've made in this PR. |
558d2d7
to
20c4fec
Compare
@yonzhan - CI issues are fixed now. |
c3d9b43
to
8902fa6
Compare
8902fa6
to
4c78394
Compare
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --ip-families ipv4,ipv6
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.