[confcom] fragment bug fixes and katapolicygen tooling update #8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| confcom acifragmentgen | cmd confcom acifragmentgen added parameter image_target |
||
| confcom acifragmentgen | cmd confcom acifragmentgen added parameter omit_id |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
🚫All pull requests will be blocked to merge until Jan 6, 2025 due to CCOA |
|
github-actions
bot
added
the
release-version-block
github-actions
bot
removed
the
release-version-block
kairu-ms
approved these changes
Jan 7, 2025
|
[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/msazure/One/_build/results?buildId=111852029&view=results |
ksayid
pushed a commit
to SethHollandsworth/azure-cli-extensions
that referenced
this pull request
Jan 8, 2025
…8393) * updating docs and bugfix for fragments * decoupling fragment feed from image push target * adding --omit-id to acifragmentgen * updating version number * adding bugfix and test for persistent volume template * consolidating to version 1.1.2 from 1.1.3 * style fixes * fixing tests * commenting out some tests for now until we figure out how to run the bash script * updating rules * updating version number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up new tooling for
genpolicy, and adding bug fixes and feature additions toacifragmentgen. Some tests are commented out. They will be uncommented once a bug in them is figured out.This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az confcom
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.