Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Containerapp] az containerapp create/update: Fix --bind/--unbind when cloud is not AzureCloud #8405

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

Greedygre
Copy link
Contributor

@Greedygre Greedygre commented Jan 8, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp create/updtae: Fix --bind/--unbind for java component when cloud is not AzureCloud
Currently when customer is using AzureChinaCloud, the command throw error due to it always list service connector, but service connector is not supported on AzureChinaCloud.

cli.azure.cli.core.azclierror: (pii). Status: Response_Status.Status_IncorrectConfiguration, Error code: 3399614475, Tag: 508634112

image

Tested by change the location to chinaeast3:
image

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 8, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 8, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jan 8, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jan 8, 2025

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.1.0b2 in src/containerapp/setup.py

Notes

@yanzhudd
Copy link
Contributor

yanzhudd commented Jan 8, 2025

please add some tests for the fix to verify if it could meet your expectations.

@Greedygre
Copy link
Contributor Author

Greedygre commented Jan 8, 2025

please add some tests for the fix to verify if it could meet your expectations.

Hi @yonzhan
The test test_containerapp_java_component has cover my case, change the config location to chinaeast3 then run the test can pass.
image

@yanzhudd yanzhudd merged commit 1488170 into Azure:main Jan 8, 2025
30 of 31 checks passed
ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants