-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Containerapp] az containerapp create/update
: Fix --bind/--unbind when cloud is not AzureCloud
#8405
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @Greedygre, |
Hi @Greedygre, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
Hi @Greedygre Release SuggestionsModule: containerapp
Notes
|
please add some tests for the fix to verify if it could meet your expectations. |
Hi @yonzhan |
…hen cloud is not AzureCloud (Azure#8405)
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp create/updtae
: Fix --bind/--unbind for java component when cloud is not AzureCloudCurrently when customer is using AzureChinaCloud, the command throw error due to it always list service connector, but service connector is not supported on AzureChinaCloud.
cli.azure.cli.core.azclierror: (pii). Status: Response_Status.Status_IncorrectConfiguration, Error code: 3399614475, Tag: 508634112
Tested by change the location to chinaeast3:
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.