Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NeworkCloud : Azure cli extension updates for Networkcloud Api 2024-10-01-preview #8415

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

priyamshet
Copy link
Member

@priyamshet priyamshet commented Jan 13, 2025


NeworkCloud : Azure cli extension updates for Networkcloud Api 2024-10-01-preview
Corresponding AAZ PR https://github.com/Azure/aaz/pull/673/files
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 13, 2025

❌Azure CLI Extensions Breaking Change Test
❌networkcloud
rule cmd_name rule_message suggest_message
1007 - ParaRemove networkcloud cluster create cmd networkcloud cluster create removed parameter analytics_workspace_id please add back parameter analytics_workspace_id for cmd networkcloud cluster create
1007 - ParaRemove networkcloud cluster create cmd networkcloud cluster create removed parameter secret_archive please add back parameter secret_archive for cmd networkcloud cluster create
1007 - ParaRemove networkcloud cluster update cmd networkcloud cluster update removed parameter secret_archive please add back parameter secret_archive for cmd networkcloud cluster update
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter analytics_output_settings
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter secret_archive_settings
⚠️ 1006 - ParaAdd networkcloud cluster create cmd networkcloud cluster create added parameter vulnerability_scanning_settings
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter analytics_output_settings
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter secret_archive_settings
⚠️ 1006 - ParaAdd networkcloud cluster update cmd networkcloud cluster update added parameter vulnerability_scanning_settings
⚠️ 1011 - SubgroupAdd networkcloud clustermanager identity sub group networkcloud clustermanager identity added
⚠️ 1006 - ParaAdd networkcloud virtualmachine create cmd networkcloud virtualmachine create added parameter console_extended_location
⚠️ 1010 - ParaPropUpdate networkcloud virtualmachine create cmd networkcloud virtualmachine create update parameter vm_device_model: updated property choices from ['T1', 'T2'] to ['T1', 'T2', 'T3']

Copy link

Hi @priyamshet,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@priyamshet priyamshet changed the title Azure cli extension updates for Networkcloud Api 2024-10-01-preview NeworkCloud : Azure cli extension updates for Networkcloud Api 2024-10-01-preview Jan 13, 2025
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jan 13, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 13, 2025
@yonzhan yonzhan requested review from kairu-ms and jsntcy January 14, 2025 00:01
@yonzhan
Copy link
Collaborator

yonzhan commented Jan 14, 2025

NeworkCloud

@priyamshet priyamshet marked this pull request as ready for review January 14, 2025 14:37
@AllyW AllyW added the preview release extension module as preview label Jan 15, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 15, 2025
@priyamshet
Copy link
Member Author

@kairu-ms Can we request a review on this PR please and also the corresponding AAZ PR https://github.com/Azure/aaz/pull/673/files

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@kairu-ms
Copy link
Contributor

Please fix the CI issue.

@kairu-ms
Copy link
Contributor

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@priyamshet
Copy link
Member Author

/asp run

@priyamshet
Copy link
Member Author

@kairu-ms can we request a re-review please

@necusjz
Copy link
Member

necusjz commented Jan 21, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz
Copy link
Member

necusjz commented Jan 28, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@necusjz necusjz merged commit 0fb0740 into Azure:main Jan 28, 2025
22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ networkcloud-3.0.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=113601860&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview release extension module as preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants