Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address python warnings from comment blocks in resource-graph extension #8418

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

yangmsft
Copy link


After AZ CLI 2.65.0 there is a Python warning originating from some comment sections in resource-graph extension, due to backslash escaping:

C:.azure\cliextensions\resource-graph\azext_resourcegraph\vendored_sdks\resourcegraph\models_models_py3.py:53: SyntaxWarning: invalid escape sequence '\ '
"""An interval in time specifying the date and time for the inclusive start and exclusive end, i.e. [start, end).
C:.azure\cliextensions\resource-graph\azext_resourcegraph\vendored_sdks\resourcegraph\models_models_py3.py:1196: SyntaxWarning: invalid escape sequence '\ '

The comment block involving backslash is largely redundant, hence this PR removes it. This does not change code logic in any way.

Related command

az graph

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

Hi @yangmsft,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 15, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Jan 15, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 15, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants