Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI for Virtual Network Gateway NAT feature #17719

Closed
gsumit10 opened this issue Apr 15, 2021 · 10 comments
Closed

CLI for Virtual Network Gateway NAT feature #17719

gsumit10 opened this issue Apr 15, 2021 · 10 comments
Assignees
Labels
Doing feature-request Network az network vnet/lb/nic/dns/etc...
Milestone

Comments

@gsumit10
Copy link

gsumit10 commented Apr 15, 2021

Resource Provider
Microsoft.Network

Description of Feature or Work Requested
Need CLI changes to support NAT feature in VirtualNetworkGateway resource.
VirtualNetworkGateway resource is for the VPN gateway for Hybrid connectivity. We are introducing a new feature to add NAT capabilities to VPN Gateway. Here user can create multiple NAT rules within the gateway and then associate them to VirtualNetworkGatewayConnection.

Minimum API Version Required
2021-02-01

Swagger Link
Azure/azure-rest-api-specs#13481
Azure/azure-rest-api-specs#13734 (minor fix added later)

Target Date
4/31/2021

Please contact Khushboo ( [email protected] ) and me ([email protected]) for any questions on the swagger PR or NAT feature.

@ghost ghost added the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 15, 2021
@gsumit10
Copy link
Author

@Khushboo-Baheti for any comments on swagger/NAT feature

@yonzhan yonzhan added the Network az network vnet/lb/nic/dns/etc... label Apr 15, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 15, 2021
@yonzhan yonzhan added feature-request needs-triage This is a new issue that needs to be triaged to the appropriate team. labels Apr 15, 2021
@ghost ghost removed the needs-triage This is a new issue that needs to be triaged to the appropriate team. label Apr 15, 2021
@yonzhan yonzhan added this to the S187 milestone Apr 15, 2021
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 15, 2021

network

@yonzhan yonzhan modified the milestones: S187, S188 Apr 21, 2021
@msyyc
Copy link
Member

msyyc commented Apr 22, 2021

@gsumit10 the api-version '2021-02-01' have not been merged into 'master' branch. After the PR merged, we will ask SDK team to release Python SDK. It will take 1-2 weeks. After SDK ready, we need to bump to new SDK for azure-cli. It will take 1~2 weeks. Then it is ok to develop this feature. So it is very hard to catch up with the target date. Could we deliver the feature in S188?

@gsumit10
Copy link
Author

gsumit10 commented Apr 22, 2021 via email

@msyyc
Copy link
Member

msyyc commented Apr 22, 2021

@gsumit10
About 'Can we target an earlier api version?'. What is the meaning of it? Now azure-cli is using '2020-11-01'.

@gsumit10
Copy link
Author

gsumit10 commented Apr 22, 2021

@msyyc , can you please share your alias and we can discuss this on teams (or reach out to me @ sumigup on teams)? i understand that sdk is not yet generated but we have done powershell work with private sdk etc to make sure our side changes and validation are done and we are not waiting on sdk release as that has been pending for a couple of months now.

@jsntcy
Copy link
Member

jsntcy commented Apr 23, 2021

@gsumit10, Yuchao's alias is yuchaoyan, you can contact him in Teams.
So you want us to develop CLI using private SDK to validate your changes before public SDK is released?

@gsumit10
Copy link
Author

Thanks @jsntcy , Will discuss with Yuchao. Working with a private SDK can help us make progress on the changes. thats what we did with powershell as well. Please let me know if there are any issues.

@gsumit10
Copy link
Author

Thanks @msyyc , can you share the timeline for the CLI release

@msyyc
Copy link
Member

msyyc commented May 21, 2021

new azure-cli will be released in about 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Doing feature-request Network az network vnet/lb/nic/dns/etc...
Projects
None yet
Development

No branches or pull requests

4 participants