-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests still import mock #18976
Tests still import mock #18976
Comments
telemetry |
Per https://pypi.org/project/mock/:
As Azure CLI requires Python >= 3.6, we can drop Actually, this is not the only place where |
@jiasli That would be really helpful for me as I try to package Azure CLI (and the SDK) in Fedora! |
By the way, did you encounter any error in Python 3.10? |
Not much in the code itself, but I do notice some testing failures there (using |
@major, I am not aware of that. Could you share some example failures caused by |
I'll try to take a look later today. |
Describe the bug
The
azure-cli-telemetry
tests still containimport mock
and mock is deprecated in recent python versions.To Reproduce
Run tests for
azure-cli-telemetry
on Python 3.10.Expected behavior
I expect tests to pass.
Environment summary
Installed
azure-cli-telemetry
1.0.6 viapip
.Additional context
I'm preparing a PR to fix this.
The text was updated successfully, but these errors were encountered: