Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop mock library #313

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Drop mock library #313

merged 1 commit into from
Jul 28, 2021

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Jul 28, 2021 •
edited
Loading

Fix Azure/azure-cli#18976

Per https://pypi.org/project/mock/:

mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.

As Azure CLI requires Python >= 3.6, we can drop mock.

@jiasli jiasli requested a review from kairu-ms July 28, 2021 04:08
@jiasli jiasli merged commit c94bff4 into Azure:dev Jul 28, 2021
@jiasli jiasli deleted the drop-mock branch July 28, 2021 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kairu-ms kairu-ms kairu-ms approved these changes

Assignees

@jiasli jiasli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests still import mock
2 participants
@jiasli @kairu-ms